wayland/layer: In arrange(), handle exclusive zone surfaces first
#1819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaLTeR
reviewed
Sep 10, 2025
src/desktop/wayland/layer.rs
Outdated
Comment on lines
276
to
283
| matches!( | ||
| with_states(l.wl_surface(), |states| states | ||
| .cached_state | ||
| .get::<LayerSurfaceCachedState>() | ||
| .current() | ||
| .exclusive_zone), | ||
| ExclusiveZone::Exclusive(_) | ||
| ) |
There was a problem hiding this comment.
I'd extract this part into a let is_exclusive = |layer| ..., also perhaps this needs further anchor checks as described and done below?
If the surface is:
- not anchored
- anchored to only two perpendicular edges (a corner),
- anchored to only two parallel edges or anchored to all edges,
The exclusive value should be treated the same as ExclusiveZone::Neutral.
There was a problem hiding this comment.
I was thinking the exclusive zone check could be moved to just a (probably private) method of struct LayerSurface.
Good catch on those other cases that are equivalent to ExclusiveZone::Neutral. Though I guess iteration order doesn't matter for "neutral" surfaces, since they shouldn't be affected by exclusive zones, or cause effects on other surfaces.
Iterate over surfaces that have an exclusive zone first, then other surfaces. This allows a surface that doesn't have an exclusive zone to be moved or resized for a later surface that does have an exclusive zone. As is probably desired.
ids1024
force-pushed
the
layer-shell-arrange
branch
from
984cd7a to
223ac50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iterate over surfaces that have an exclusive zone first, then other surfaces. This allows a surface that doesn't have an exclusive zone to be moved or resized for a later surface that does have an exclusive zone. As is probably desired.
This does help with a test client, but not with the client I was trying to fix; so I need to do a bit more testing here...