Feat/observer summary UI #1770
Open
Feat/observer summary UI #1770
+458
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h list and info view; formatting fixes
Introduces logic to capture and set the original size of the player name label, ensuring its height is adjusted appropriately when displaying player information in the observer control bar. This improves UI consistency and prevents layout issues when the label content changes.
Author
|
Skyaero42
requested changes
Nov 1, 2025
Skyaero42
left a comment
Skyaero42
left a comment
There was a problem hiding this comment.
I started reviewing this, but this is written by AI without human supervision.
Additionally, I dont think this is the way forward for observer view. There are great overlays made by e.g. Legi look better and provide a lot more information.
|
|
||
| if (cash >= 1000000) | ||
| { | ||
| if ((cash % 1000000) == 0) |
| } | ||
| else if (cash >= 1000) | ||
| { | ||
| if ((cash % 1000) == 0) |
There was a problem hiding this comment.
Unneccesary, displaying 1.0k is perfectly fine
| } | ||
| else | ||
| { | ||
| const float millions = static_cast<float>(cash) / 1000000.0f; |
| } | ||
| else | ||
| { | ||
| const float thousands = static_cast<float>(cash) / 1000.0f; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.