bugfix(filesystem): Prevent loading wrong INIZH.big from Data/INI directory to prevent INI CRC mismatch

[bobtista]

• Fixes Duplicate and outdated INIZH.big file is not cleaned up on EA app/origin installs and is loaded #1179

This change skips loading any BIG file matching Data\INI\INIZH.big during archive initialization.

Testing

1. Install the game from EA App/Origin
2. Observe two INIZH.big files, one in the root folder and one in Data/INI
3. Run the game; notice that DeleteFile/cleanup code does not successfully delete it (this is expected and acceptable now)
4. Try to join a multiplayer game which performs CRC checks — CRC should now match
5. Play the multiplayer game — no mismatches should occur (From this issue)

[xezon]

Where is the Delete code? Can that be removed if it does not work anyway?

[bobtista]

Where is the Delete code? Can that be removed if it does not work anyway?

GeneralsMD/Code/GameEngine/Source/Common/GameEngine.cpp line 402, and we can remove it yes. I'm unsure if it works on other installs eg the original CD, but we don't need it in any case. Remove it?

[xezon]

I would say if this new change avoids all trouble, then remove the hack from Kris and transfer his original comment to the new hack to clarify the intention.

[xezon]

notice that DeleteFile/cleanup code does not successfully delete it (this is expected and acceptable now)

Why does it not delete it? Does it fail because it does not have Admin privileges?

[bobtista]

notice that DeleteFile/cleanup code does not successfully delete it (this is expected and acceptable now)

Why does it not delete it? Does it fail because it does not have Admin privileges?

Yes, from the issue "this does not work on the EA app/origin version of the game because the folder is owned by the app and is not writable."

[xezon]

Remove it?

Yes. Move the EA comment to the new place.

[bobtista]

Yes. Move the EA comment to the new place.

Done

[xezon]

Looks good.