Repository navigation
Feat/reminder interval - #614
bugrakocabay wants to merge 10 commits into
Conversation
TwiN
left a comment
There was a problem hiding this comment.
Few comments, but looks good overall.
|
I want this! |
|
Wow I'm really sorry for forgetting about this for so long! @bugrakocabay any chance you can resolve the conflict and ping me when it's done? I'll get this merged and released ASAP |
TwiN
left a comment
There was a problem hiding this comment.
Can this be renamed to MinimumRepeatInterval?
Because it doesn't necessarily happen every repeat interval given that the evaluation is driven by the normal interval. For instance, if the interval is set to 5m and the repeat interval is set to 7m, the alert would only be sent on the 2nd evaluation (so after 10m), not after the repeat interval of 7m
|
This would be great! |
|
@bugrakocabay could you please merge bugrakocabay#1, I hope its only a one obstacle to merge this. |
|
thanks for this feature! hope it gets merged soon 🥇 |
|
Any chance this will be merged anytime soon? |
@nosovk This was merged into the wrong branch, so it's not reflected here. @bugrakocabay this needs that to be addressed and also rebased. I'll wait a little while and if not done will fork your fork, make the required changes and open a new PR so we can try to get this moving forward. |
|
#1138 has been implemented. If some of you are still interested in the feature, I'd love a confirmation that it works as intended on your end. Should only be available under the latest tag for now. |
Hi @TwiN
Summary
Regarding this issue #599.
Checklist
README.md, if applicable.