Skip to content

Feat/reminder interval - #614

Closed
bugrakocabay wants to merge 10 commits into
TwiN:masterfrom
bugrakocabay:feat/reminder-interval
Closed

bugrakocabay wants to merge 10 commits into
TwiN:masterfrom
bugrakocabay:feat/reminder-interval

Conversation

@bugrakocabay

Copy link
Copy Markdown
Contributor

Hi @TwiN

Summary

Regarding this issue #599.

Checklist

  • Tested and/or added tests to validate that the changes work as intended, if applicable.
  • Updated documentation in README.md, if applicable.

@TwiN TwiN left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments, but looks good overall.

Comment thread watchdog/alerting.go Outdated
Comment thread alerting/alert/alert.go Outdated
@bugrakocabay
bugrakocabay requested review from TwiN and merou April 27, 2024 12:56
@sabey sabey mentioned this pull request Sep 1, 2024
@illia-weisser

Copy link
Copy Markdown

I want this!

@TwiN

TwiN commented Dec 5, 2024

Copy link
Copy Markdown
Owner

Wow I'm really sorry for forgetting about this for so long!

@bugrakocabay any chance you can resolve the conflict and ping me when it's done? I'll get this merged and released ASAP

@TwiN TwiN left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be renamed to MinimumRepeatInterval?

Because it doesn't necessarily happen every repeat interval given that the evaluation is driven by the normal interval. For instance, if the interval is set to 5m and the repeat interval is set to 7m, the alert would only be sent on the 2nd evaluation (so after 10m), not after the repeat interval of 7m

@TwiN TwiN added feature New feature or request area/alerting Related to alerting labels Dec 5, 2024
@sachasmart

Copy link
Copy Markdown

This would be great!

@nosovk

nosovk commented Feb 12, 2025

Copy link
Copy Markdown
Contributor

@bugrakocabay could you please merge bugrakocabay#1, I hope its only a one obstacle to merge this.

@saul-salazar-dotcom

Copy link
Copy Markdown

thanks for this feature! hope it gets merged soon 🥇

@ViktorZieg

Copy link
Copy Markdown
Contributor

Any chance this will be merged anytime soon?

@onedr0p

onedr0p commented Aug 4, 2025 •

Copy link
Copy Markdown
Contributor

@bugrakocabay could you please merge bugrakocabay#1, I hope its only a one obstacle to merge this.

@nosovk This was merged into the wrong branch, so it's not reflected here. @bugrakocabay this needs that to be addressed and also rebased. I'll wait a little while and if not done will fork your fork, make the required changes and open a new PR so we can try to get this moving forward.

@onedr0p

onedr0p commented Aug 4, 2025 •

Copy link
Copy Markdown
Contributor

Actually looks like we can close this in favor of #1138, all authors have been carried over.

@TwiN what do you think?

@TwiN

TwiN commented Aug 4, 2025

Copy link
Copy Markdown
Owner

Good point @onedr0p

Closing in favor of #1138

@TwiN TwiN closed this Aug 4, 2025
@TwiN

TwiN commented Aug 8, 2025

Copy link
Copy Markdown
Owner

#1138 has been implemented.

If some of you are still interested in the feature, I'd love a confirmation that it works as intended on your end.

Should only be available under the latest tag for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/alerting Related to alerting feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants