Repository navigation
feat(alerting): Implement alert reminders - #1138
Merged
Merged
Conversation
… interval to run alert consecutively
MinimumRepeatInterval
# Conflicts: # README.md # alerting/alert/alert.go # watchdog/alerting.go # watchdog/alerting_test.go
ViktorZieg
marked this pull request as ready for review
June 18, 2025 10:34
(cherry picked from commit 9b2161556bddf01d385f97dafac2515857190ae5)
|
Would love this feature! |
TwiN
requested changes
Aug 4, 2025
TwiN
requested changes
Aug 4, 2025
TwiN
approved these changes
Aug 8, 2025
| if alertProvider != nil { | ||
| logr.Infof("[watchdog.handleAlertsToTrigger] Sending %s alert because alert for endpoint with key=%s with description='%s' has been TRIGGERED", endpointAlert.Type, ep.Key(), endpointAlert.GetDescription()) | ||
| var err error | ||
| alertType := "reminder" |
TwiN
changed the title
Owner
|
Thank you for the contribution! |
1 of 2 tasks
|
Looks like the build failed @TwiN |
Owner
|
@day1118 Good catch. I re-ran it when it failed first, but seems like it had failed a 2nd time and I missed it. I'll have a look. |
Owner
|
It's taken care of. Has anybody had the opportunity to try it yet? |
Closed
2 tasks done
alexlebens
pushed a commit
to alexlebens/infrastructure
that referenced
this pull request
Aug 11, 2025
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/twin/gatus](https://github.com/TwiN/gatus) | minor | `v5.21.0` -> `v5.22.0` | --- ### Release Notes <details> <summary>TwiN/gatus (ghcr.io/twin/gatus)</summary> ### [`v5.22.0`](https://github.com/TwiN/gatus/releases/tag/v5.22.0) [Compare Source](TwiN/gatus@v5.21.0...v5.22.0) #### What's Changed - feat(alerting): Implement alert reminders by [@​ViktorZieg](https://github.com/ViktorZieg) in TwiN/gatus#1138 - feat(metrics): add support for custom labels in Prometheus metrics by [@​appleboy](https://github.com/appleboy) in TwiN/gatus#979 - fix(metrics): improve Prometheus metrics registration by [@​appleboy](https://github.com/appleboy) in TwiN/gatus#1186 - perf: Cap RANDOM\_STRING\_N to 8182 by [@​TwiN](https://github.com/TwiN) in TwiN/gatus#1193 - docs: Add example for alerts\[].minimum-reminder-interval by [@​xconverge](https://github.com/xconverge) in TwiN/gatus#1187 - docs: Add section for gatus-sdk by [@​TwiN](https://github.com/TwiN) in TwiN/gatus#1189 #### New Contributors - [@​ViktorZieg](https://github.com/ViktorZieg) made their first contribution in TwiN/gatus#1138 - [@​xconverge](https://github.com/xconverge) made their first contribution in TwiN/gatus#1187 **Full Changelog**: TwiN/gatus@v5.21.0...v5.22.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xLjMiLCJ1cGRhdGVkSW5WZXIiOiI0MS4xLjMiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbImltYWdlIl19--> Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/1194 Co-authored-by: Renovate Bot <renovate-bot@alexlebens.net> Co-committed-by: Renovate Bot <renovate-bot@alexlebens.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Regarding this issue #379
The changes regarding this issue were made by @bugrakocabay
There is already a Pull Request open (#614), but since it has been inactive for a while, I resolved the merge conflicts, so we can get this feature.
Fixes #379
Supersedes #614
Checklist
README.md, if applicable.