Template low pass filter #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Roozki
reviewed
Oct 26, 2025
| @@ -0,0 +1,56 @@ | |||
| #ifndef FIR_FILTER_HPP | |||
| #define FIR_FILTER_HPP | |||
| #define MAX_LP_FIR_ORDER (10) | |||
Contributor
There was a problem hiding this comment.
Probably don't need a max anymore with templates, its up to the user to choose a reasonable order
Roozki
reviewed
Oct 26, 2025
| { | ||
| REQUIRE_THROWS_AS(LowPassFIRFilter(0), std::invalid_argument); | ||
| REQUIRE_THROWS_AS(LowPassFIRFilter(MAX_LP_FIR_ORDER + 1), std::invalid_argument); | ||
| REQUIRE_THROWS_AS(LowPassFIRFilter<0>(), std::invalid_argument); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? This PR is to template
ordervariable for the low pass FIR filter.Why? Templating the
orderallows static allocation of the buffer while minimizing the amount of space allocated. The previous implementation also statically allocated the buffer, but allocated more space then necessary in most cases.How?
ordervariableordervariable