Expand Number to support the full integer range #6025

ximinez · 2025-11-12T14:44:20Z

Supersedes #6000.

Update the conversion points between Number and {XRP,MPT,IOU,ST}Amount & STNumber.

High Level Overview of Change

Context of Change

Type of Change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Refactor (non-breaking change that only restructures code)
Performance (increase or change in throughput and/or latency)
Tests (you added tests for code that already exists, or your new feature included in this PR)
Documentation update
Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
Release

API Impact

Public API: New feature (new methods and/or new fields)
Public API: Breaking change (in general, breaking changes should only impact the next api_version)
libxrpl change (any change that may affect libxrpl or dependents of libxrpl)
Peer protocol change (must be backward compatible or bump the peer protocol version)

- Update the conversion points between Number and *Amount & STNumber. - Tests probably don't pass.

- Track down and fix edge cases. - Some refactoring and renaming for clarity and simplicity

- Field will be absent in RPC results instead of returning 0.

…number-simple * upstream/develop: chore: Clean up incorrect comments (6031) refactor: Retire MultiSignReserve and ExpandedSignerList amendments (5981)

- Update tests. Unfinished. - TODO: Finish Number tests. Use both modes for STNumber tests. Move mantissa_scale into MantissaRange.

- Fix cross-compiler build issues

- Nothing really needed to be changed in the tests, but I added a couple of test cases for the min and max int64.

- Added test cases min int64. - Updated numberFromJson range checking to use the larger range available from Number.

- Default Number outside of transaction processing to be "large" so RPC will work.

gregtatcam · 2025-12-18T15:27:39Z

src/xrpld/app/tx/detail/LoanPay.cpp

+    {
+        // LCOV_EXCL_START
+        [[maybe_unused]]
+        auto const available = *assetsAvailableProxy;


Why are available and total needed? They are not used.

include/xrpl/protocol/STTakesAsset.h

gregtatcam · 2025-12-18T18:21:31Z

src/xrpld/app/tx/detail/LoanBrokerCoverClawback.cpp

    sleBroker->at(sfCoverAvailable) -= clawAmount;
    view().update(sleBroker);

+    associateAsset(*sleBroker, vaultAsset);


I keep on thinking if there is a way to make this association table driven. There is already a new field property defined sMD_NeedsAsset. What if instead adding this property in sfields, it's added in ledger_entries. Then we just need a way to point it to the associated asset, which requires accessing up to two linked objects right now. What if we add an integral flag to each related ledger entry (Vault, LoanBroker, Loan) to indicate if an asset is integral? Then in STObject::applyTemplate(), which iterates over all fields , for any STNumber field with sMD_NeedsAsset, we can set the integral flag. Does it make sense to explore this approach?

…mber-simple

…nto ximinez/lending-number-simple * XRPLF/ximinez/lending-XLS-66-ongoing: Fix Overpayment ValueChange calculation in Lending Protocol (6114) Ensure vault asset cap is not exceeded (6124) Disallow pseudo accounts to be Destination for LoanBrokerCoverWithdraw (6106) Check permissions in LoanSet and LoanPay (6108) Fix some minor bugs in Lending Protocol (6101) Fix LoanBrokerSet debtMaximum limits (6116)

…mber-simple

@gregtatcam

- Prompted by review feedback from @gregtatcam. - Should be pretty thorough. - Tweaked how the MantissaRange class is instantiated, and added a couple more static_asserts.

…mber-simple

gregtatcam

Looks good to me. Thanks for adding extensive comments to the Number and MantissaRange classes.

Please add some documentation to STTakesAsset.h explaining why it's needed and how to use it. I'll approve once those are in!

* Make `maxRep` public. * Document why template normalize takes min/max params. * Add a check to normalizeToRange to ensure there are no signed/unsigned conversion issues. * static_assert that maxRep is >= maxMPTokenAmount and INITIAL_XRP at their definition points. If something ever changes so that it's not, we'll know immediately.

ximinez · 2026-01-07T19:53:15Z

Want to make sure I understood this correctly: with largeRange, we can support full precision up to 2^63 - 1, so integer types (MPT or XRP) don’t lose precision even for large values. We’re still bounded by the signed int64 limit, but this works for existing integers since none of them exceed int64.

That is correct.

However, if we ever want to go beyond the 63-bit range (e.g., increasing MPT’s MaximumAmount to max(uint64) in the future), this implementation is not sufficient.

That is correct, however my current understanding is that there is no need or plan to extend the current limit.

Such a change would require an amendment, so a second expansion of Number would need to be included in that amendment work.

The updated class documentation now explicitly mentions that the limits for Number were chosen partially because of maxMPTokenAmount.

I've added a couple of static_asserts to ensure this invariant remains true in c88dd55

@shawnxie999

- Based on feedback from @shawnxie999.

…mber-simple

- Remove redundant "else" because of early return. - Add a concept "Integral64" to use in the template parameter for normalizeToRange. - Add documentation to STTakesAsset, associateAsset, and add explanation for how `STNumber` uses it. - Assert that `numberToJson` is always outside of a Transaction context. - Remove copy of `InitialFibSeqPct` and the assert in `Number::operator*=` that prompted me to add it. - Add amendment gating to `STAmount::operator=`

ximinez added 7 commits November 12, 2025 00:31

Step 1: Convert Number to use 128-bit numbers internally

d030fda

- Update the conversion points between Number and *Amount & STNumber. - Tests probably don't pass.

fixup! Step 1: Convert Number to use 128-bit numbers internally

3048f55

fixup! fixup! Step 1: Convert Number to use 128-bit numbers internally

a32b572

Merge branch 'develop' into ximinez/lending-number-simple

3438243

Continue with Step 1

d2d403d

- Track down and fix edge cases. - Some refactoring and renaming for clarity and simplicity

fixup! Continue with Step 1

7cd48a7

Turns out there's no to_string(__int128_t)

4abb6d9

ximinez force-pushed the ximinez/lending-number-simple branch from 5cd623f to 4abb6d9 Compare November 13, 2025 05:52

ximinez added the DraftRunCI Normally CI does not run on draft PRs. This opts in. label Nov 13, 2025

ximinez added 2 commits November 13, 2025 01:53

Fix Vault unit tests for default fields with value 0.

2881aad

- Field will be absent in RPC results instead of returning 0.

Merge remote-tracking branch 'upstream/develop' into ximinez/lending-…

2eca3dc

…number-simple * upstream/develop: chore: Clean up incorrect comments (6031) refactor: Retire MultiSignReserve and ExpandedSignerList amendments (5981)

kennyzlei requested review from Bronek and shawnxie999 November 13, 2025 18:06

ximinez added 5 commits November 14, 2025 02:34

Step 2: Add the ability to change the mantissa range

606e3ec

- Update tests. Unfinished. - TODO: Finish Number tests. Use both modes for STNumber tests. Move mantissa_scale into MantissaRange.

fixup! Step 2: Add the ability to change the mantissa range

4cf22b5

- Fix cross-compiler build issues

Step 2 cont. Refactor the to_string(Number) test

6f1fe50

Add more edge case Number tests

fbcd4f3

Fix Number::power(), and a bunch of Number unit tests

9310991

ximinez force-pushed the ximinez/lending-number-simple branch from b1079c5 to 9310991 Compare November 14, 2025 23:51

ximinez added 2 commits November 14, 2025 19:06

refactor: Move the mantissa_scale enum into the MantissaRange struct

857eaff

Step 2.5: Run the STNumber tests using both mantissa sizes

c9ad49f

- Nothing really needed to be changed in the tests, but I added a couple of test cases for the min and max int64.

ximinez force-pushed the ximinez/lending-number-simple branch from b17225c to c9ad49f Compare November 15, 2025 00:41

ximinez added 5 commits November 15, 2025 00:50

Step 2.5cont: Make some updates to STNumber

595a5ee

- Added test cases min int64. - Updated numberFromJson range checking to use the larger range available from Number.

Step 3: Automatically switch precision in the transaction engine

3451d15

- Default Number outside of transaction processing to be "large" so RPC will work.

Fix some build errors - unused variables, large constants

a5f43fb

Merge branch 'develop' into ximinez/lending-number-simple

9f50cc0

Fix root2, and add tests for it

470c9c3

ximinez mentioned this pull request Nov 16, 2025

DRAFT: Number expansion #6042

Closed

13 tasks

ximinez force-pushed the ximinez/lending-number-simple branch from 470c9c3 to 248d267 Compare November 16, 2025 18:10

ximinez mentioned this pull request Nov 16, 2025

Lending Protocol implementation XLS-66 #5270

Merged

7 tasks

gregtatcam reviewed Dec 18, 2025

View reviewed changes

Merge branch 'ximinez/lending-XLS-66-ongoing' into ximinez/lending-nu…

565e62f

…mber-simple

ximinez force-pushed the ximinez/lending-number-simple branch from 451b474 to 565e62f Compare December 19, 2025 00:40

ximinez added 4 commits December 18, 2025 19:49

Merge branch 'ximinez/lending-XLS-66-ongoing' into ximinez/lending-nu…

96a9800

…mber-simple

Merge branch 'ximinez/lending-XLS-66-ongoing' into ximinez/lending-nu…

59cafb0

…mber-simple

Document the Number mantissa range switching

16ab78d

- Prompted by review feedback from @gregtatcam. - Should be pretty thorough. - Tweaked how the MantissaRange class is instantiated, and added a couple more static_asserts.

ximinez force-pushed the ximinez/lending-number-simple branch from 8c64508 to 16ab78d Compare January 6, 2026 01:17

ximinez added 3 commits January 6, 2026 11:17

fixup! Document the Number mantissa range switching

6303dd5

Merge branch 'ximinez/lending-XLS-66-ongoing' into ximinez/lending-nu…

fa6047f

…mber-simple

Merge branch 'ximinez/lending-XLS-66-ongoing' into ximinez/lending-nu…

c5c89c2

…mber-simple

gregtatcam reviewed Jan 6, 2026

View reviewed changes

ximinez added 3 commits January 7, 2026 18:32

Bring back Number::Guard::doRound* functions

a06de68

- Based on feedback from @shawnxie999.

Point back to the class documentation in mantissa() and exponent()

7265804

Merge branch 'ximinez/lending-XLS-66-ongoing' into ximinez/lending-nu…

9526a30

…mber-simple

This was referenced Jan 8, 2026

squashed: Expand Number to support full integer range as of 9526a30 #6191

Closed

squashed: Expand Number to support full integer range as of 9526a30 #6192

Open

ximinez added 8 commits January 8, 2026 17:10

Merge branch 'ximinez/lending-XLS-66-ongoing' into ximinez/lending-nu…

0136bf8

…mber-simple

Merge branch 'ximinez/lending-XLS-66-ongoing' into ximinez/lending-nu…

7c34191

…mber-simple

Merge branch 'ximinez/lending-XLS-66-ongoing' into ximinez/lending-nu…

4303e67

…mber-simple

Merge branch 'ximinez/lending-XLS-66-ongoing' into ximinez/lending-nu…

b11a7fa

…mber-simple

Merge branch 'ximinez/lending-XLS-66-ongoing' into ximinez/lending-nu…

a428a75

…mber-simple

fixup! Review feedback from @shawnxie999 and @gregtatcam

04a98fb

fixup! fixup! Review feedback from @shawnxie999 and @gregtatcam

7782785

kennyzlei requested review from gregtatcam and shawnxie999 January 9, 2026 03:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Expand Number to support the full integer range #6025

Expand Number to support the full integer range #6025

ximinez commented Nov 12, 2025 •

edited

Loading

Uh oh!

gregtatcam Dec 18, 2025

Uh oh!

Uh oh!

gregtatcam Dec 18, 2025

Uh oh!

gregtatcam left a comment

Uh oh!

ximinez commented Jan 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Expand Number to support the full integer range #6025

Are you sure you want to change the base?

Expand Number to support the full integer range #6025

Conversation

ximinez commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

High Level Overview of Change

Context of Change

Type of Change

API Impact

Uh oh!

gregtatcam Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gregtatcam Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

gregtatcam left a comment

Choose a reason for hiding this comment

Uh oh!

ximinez commented Jan 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ximinez commented Nov 12, 2025 •

edited

Loading