Skip to content

fix: Remaining clang-tidy unchecked optionals - #6979

Merged
bthomee merged 5 commits into
XRPLF:developfrom
godexsoft:fix/clang-tidy-optional
Apr 23, 2026
Merged

fix: Remaining clang-tidy unchecked optionals#6979
bthomee merged 5 commits into
XRPLF:developfrom
godexsoft:fix/clang-tidy-optional

Address review comments

7c52293
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Apr 21, 2026 in 1s

87.2% of diff hit (target 82.5%)

View this Pull Request on Codecov

87.2% of diff hit (target 82.5%)

Annotations

Check warning on line 272 in include/xrpl/protocol/PublicKey.h

See this annotation in the file changed.

@codecov codecov / codecov/patch

include/xrpl/protocol/PublicKey.h#L272

Added line #L272 was not covered by tests

Check warning on line 154 in src/libxrpl/tx/paths/OfferStream.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/libxrpl/tx/paths/OfferStream.cpp#L154

Added line #L154 was not covered by tests

Check warning on line 657 in src/xrpld/rpc/detail/PathRequest.cpp

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/xrpld/rpc/detail/PathRequest.cpp#L657

Added line #L657 was not covered by tests