Prevent windows hits from being used as anchors#56
Merged
aevyrie merged 3 commits intoaevyrie:mainfrom Feb 9, 2026
Merged
Conversation
GrandChaman
commented
Dec 10, 2025
| // Since `bevy` 0.17.3: | ||
| // | ||
| // If the current hit is on a window, we cannot use the `hit.position` as an anchor | ||
| // as the `hit.position` is in viewport coordinates. |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| // as the `hit.position` is in viewport coordinates. | |
| // as the `hit.position` is in screen coordinates. |
I have a doubt on which is the correct nomenclature here.
Closed
|
Great Pr! |
|
I have tested and confirmed it does indeed fix the issue. |
This was referenced Jan 14, 2026
Owner
|
This needs a clippy fix before it can be merged. |
aevyrie
approved these changes
Jan 17, 2026
Contributor
Author
I chose to silence the warning as to not mix refactoring with the fix. Hope that's ok! |
Owner
|
Released as v0.7.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of the fix described in #55.
Changes can be reviewed per commits.