Skip to content

[chore](typo)Fix typos in thrift #57267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 24, 2025
Merged

[chore](typo)Fix typos in thrift #57267

merged 2 commits into from
Oct 24, 2025
+19 −19

Conversation

@uchenily
Copy link
Contributor

@uchenily uchenily commented Oct 23, 2025 •
edited
Loading

In Thrift, fields are distinguished by IDs rather than names, so modifying field names does not break compatibility.

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@uchenily
Copy link
Contributor Author

run buildall

yiguolei
yiguolei reviewed Oct 23, 2025
View reviewed changes
gensrc/thrift/DataSinks.thrift
}

enum TResultSinkType {
MYSQL_PROTOCAL = 0,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

every field in thrift has an ID. You can change the name. It is compatible.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been verified to be true, thanks~, I will update it later.

@hello-stephen
Copy link
Contributor

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 80.62% (1647/2043)
Line Coverage 66.99% (29056/43376)
Region Coverage 67.27% (14374/21368)
Branch Coverage 57.67% (7643/13254)

@uchenily
Copy link
Contributor Author

run buildall

@uchenily uchenily requested a review from yiguolei October 23, 2025 08:20
@uchenily uchenily changed the title [chore](typo)Fix typos in thrift with backward compatibility [chore](typo)Fix typos in thrift Oct 23, 2025
@doris-robot
Copy link

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 80.62% (1647/2043)
Line Coverage 66.98% (29054/43376)
Region Coverage 67.31% (14382/21368)
Branch Coverage 57.68% (7645/13254)

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 75.00% (3/4) 🎉
Increment coverage report
Complete coverage report

@doris-robot
Copy link

ClickBench: Total hot run time: 28.41 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ee75e10f3d8a6703347bef08d12fb50634a2b3d5, data reload: false

query1	0.04	0.04	0.04
query2	0.12	0.06	0.06
query3	0.30	0.07	0.07
query4	1.61	0.09	0.08
query5	0.27	0.26	0.26
query6	1.19	0.68	0.65
query7	0.04	0.03	0.02
query8	0.07	0.06	0.06
query9	0.68	0.54	0.53
query10	0.60	0.60	0.59
query11	0.26	0.14	0.15
query12	0.27	0.14	0.14
query13	0.64	0.63	0.62
query14	1.03	1.03	1.02
query15	0.95	0.88	0.86
query16	0.40	0.39	0.39
query17	1.02	1.04	1.03
query18	0.24	0.21	0.23
query19	2.03	1.84	1.78
query20	0.01	0.01	0.02
query21	15.41	0.29	0.24
query22	5.00	0.11	0.10
query23	15.36	0.41	0.23
query24	2.91	0.46	0.32
query25	0.10	0.09	0.09
query26	0.20	0.18	0.18
query27	0.10	0.10	0.09
query28	3.68	1.26	1.05
query29	12.55	4.12	3.39
query30	0.34	0.12	0.10
query31	2.84	0.64	0.44
query32	3.24	0.61	0.50
query33	3.12	3.04	3.16
query34	16.30	5.24	4.54
query35	4.53	4.49	4.55
query36	0.65	0.52	0.52
query37	0.23	0.10	0.09
query38	0.19	0.06	0.07
query39	0.05	0.06	0.05
query40	0.20	0.18	0.17
query41	0.11	0.06	0.06
query42	0.08	0.05	0.05
query43	0.06	0.05	0.05
Total cold run time: 99.02 s
Total hot run time: 28.41 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/9) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.62% (17938/34089)
Line Coverage 37.85% (162753/429946)
Region Coverage 32.26% (124070/384568)
Branch Coverage 33.68% (54372/161443)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (9/9) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.02% (23771/33471)
Line Coverage 57.42% (247075/430295)
Region Coverage 52.51% (204697/389834)
Branch Coverage 54.33% (88249/162434)

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 75.00% (3/4) 🎉
Increment coverage report
Complete coverage report

@uchenily
Copy link
Contributor Author

run nonConcurrent external

@uchenily
Copy link
Contributor Author

run external

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (9/9) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.05% (23782/33471)
Line Coverage 57.45% (247207/430295)
Region Coverage 52.52% (204751/389834)
Branch Coverage 54.35% (88288/162434)

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 75.00% (3/4) 🎉
Increment coverage report
Complete coverage report

@uchenily
Copy link
Contributor Author

run nonConcurrent

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 24, 2025
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (9/9) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.32% (23870/33471)
Line Coverage 57.74% (248464/430295)
Region Coverage 52.93% (206333/389834)
Branch Coverage 54.64% (88755/162434)

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 75.00% (3/4) 🎉
Increment coverage report
Complete coverage report

@yiguolei yiguolei merged commit 84c1966 into apache:master Oct 24, 2025
30 of 31 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 24, 2025
@uchenily
[chore](typo)Fix typos in thrift (#57267)
30f27bd 
In Thrift, fields are distinguished by IDs rather than names, so
modifying field names does not break compatibility.
@github-actions github-actions bot mentioned this pull request Oct 24, 2025
Open
yiguolei pushed a commit that referenced this pull request Oct 25, 2025
@uchenily @yiguolei
[chore](typo)Fix typos in thrift (#57267)
7efb8ec 
In Thrift, fields are distinguished by IDs rather than names, so
modifying field names does not break compatibility.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

@zclllyybb zclllyybb zclllyybb approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.x reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@uchenily @hello-stephen @doris-robot @yiguolei @zclllyybb