Generate config/effector descriptions for yaml-only blueprints#1176
Generate config/effector descriptions for yaml-only blueprints#1176ivanayov wants to merge 1 commit intoapache:masterfrom
Conversation
|
LGTM. One comment though. This generate a JS file which encapsulates the JSON data into a JS var. While this is ok for the documentation as it imports the file directly, it's a bit tedious to share the info with other services (i.e. community catalog) as we will need to |
There was a problem hiding this comment.
This will read config from the user's brooklyn.properties. Better initialize it with an empty state using new LocalManagementContext(BrooklynProperties.Factory.newEmpty());
782e2b7 to
186c175
Compare
|
Jenkins fails due to |
186c175 to
aab2fc9
Compare
|
@bostko Didn't notice that. Let's not reintroduce a slow process then. However, I quite like the @iyovcheva's idea of generate the |
|
test failure is clearly unrelated, maybe close and reopen to run again. meanwhile we should look at this /cc @aledsage : |
|
(easily fixed - the test was doing an immediate assert on something happening in another thread; PR to follow; @iyovcheva give it an hour or so for the other fix to land then please close+reopen this to run the jenkins tests again) |
aab2fc9 to
7774e46
Compare
7774e46 to
e6d8fb2
Compare
No description provided.