-
Notifications
You must be signed in to change notification settings - Fork 65
Remove XCode 15/ Swift 5 CI tests #706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
AnthonyMDev
wants to merge
1
commit into
v2-staging
Choose a base branch
from
v2-ci-fixes
base: v2-staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
name: "CI Tests (Xcode 15.4)" | ||
name: "CI Tests (Xcode 16.4)" | ||
|
||
on: | ||
pull_request: | ||
types: [opened, synchronize, reopened] | ||
|
||
env: | ||
XCODE_VERSION: "15.4" | ||
XCODE_VERSION: "16.4" | ||
|
||
jobs: | ||
changes: | ||
|
@@ -40,7 +40,7 @@ jobs: | |
- '.tuist-version' | ||
|
||
tuist-generation: | ||
runs-on: macos-latest | ||
runs-on: macos-15 | ||
needs: [changes] | ||
if: ${{ needs.changes.outputs.ios == 'true' || needs.changes.outputs.codegen == 'true' || needs.changes.outputs.pagination == 'true' || needs.changes.outputs.tuist == 'true' }} | ||
timeout-minutes: 8 | ||
|
@@ -63,7 +63,7 @@ jobs: | |
key: ${{ github.run_id }}-dependencies | ||
|
||
run-swift-builds: | ||
runs-on: macos-latest | ||
runs-on: macos-15 | ||
timeout-minutes: 15 | ||
strategy: | ||
fail-fast: false | ||
|
@@ -85,7 +85,7 @@ jobs: | |
cd ${{ matrix.package }} && swift build | ||
|
||
build-and-unit-test: | ||
runs-on: macos-latest | ||
runs-on: macos-15 | ||
needs: [tuist-generation, changes] | ||
timeout-minutes: 20 | ||
strategy: | ||
|
@@ -136,16 +136,6 @@ jobs: | |
./Derived/* | ||
key: ${{ github.run_id }}-dependencies | ||
fail-on-cache-miss: true | ||
# Caching for apollo-ios and apollo-ios-codegen SPM dependencies | ||
# - uses: actions/cache@v3 | ||
# with: | ||
# path: ./DerivedData/SourcePackages | ||
# key: ${{ runner.os }}-spm-${{ hashFiles('./apollo-ios/Package.resolved') }}-${{ hashFiles('./apollo-ios-codegen/Package.resolved') }} | ||
# - name: Run Tuist Generation | ||
# uses: tuist/[email protected] | ||
# with: | ||
# command: 'generate' | ||
# arguments: '' | ||
- name: Build and Test | ||
if: ${{ matrix.should-run == true || matrix.should-run == 'true' }} | ||
id: build-and-test | ||
|
@@ -188,73 +178,4 @@ jobs: | |
path: | | ||
TestResults/ResultBundle.zip | ||
|
||
run-codegen-test-configurations: | ||
runs-on: macos-latest | ||
timeout-minutes: 20 | ||
name: Codegen Test Configurations - macOS | ||
steps: | ||
- uses: maxim-lobanov/setup-xcode@v1 | ||
with: | ||
xcode-version: ${{ env.XCODE_VERSION }} | ||
- name: Checkout Repo | ||
uses: actions/checkout@v3 | ||
- name: Test Codegen Configurations | ||
shell: bash | ||
run: | | ||
./scripts/run-test-codegen-configurations.sh -t | ||
|
||
verify-frontend-bundle-latest: | ||
runs-on: macos-latest | ||
needs: [changes] | ||
if: ${{ needs.changes.outputs.codegen == 'true' }} | ||
timeout-minutes: 5 | ||
name: Verify Frontend Bundle Latest - macOS | ||
steps: | ||
- name: Checkout Repo | ||
uses: actions/checkout@v3 | ||
- name: Build JS Bundle | ||
shell: bash | ||
working-directory: apollo-ios-codegen/Sources/GraphQLCompiler/JavaScript | ||
run: ./auto_rollup.sh | ||
- name: Verify Latest | ||
shell: bash | ||
run: | | ||
git diff --exit-code | ||
|
||
verify-cli-binary-archive: | ||
runs-on: macos-latest | ||
needs: [changes] | ||
if: ${{ needs.changes.outputs.codegen == 'true' }} | ||
timeout-minutes: 5 | ||
name: Verify CLI Binary Archive - macOS | ||
steps: | ||
- name: Checkout Repo | ||
uses: actions/checkout@v3 | ||
- name: Extract CLI Binary | ||
shell: bash | ||
working-directory: apollo-ios/CLI | ||
run: tar -xf apollo-ios-cli.tar.gz apollo-ios-cli | ||
- name: Verify Version | ||
shell: bash | ||
working-directory: apollo-ios/scripts | ||
run: ./cli-version-check.sh | ||
|
||
run-cocoapods-integration-tests: | ||
runs-on: macos-latest | ||
timeout-minutes: 20 | ||
name: Cocoapods Integration Tests - macOS | ||
steps: | ||
- uses: maxim-lobanov/setup-xcode@v1 | ||
with: | ||
xcode-version: ${{ env.XCODE_VERSION }} | ||
- name: Checkout Repo | ||
uses: actions/checkout@v3 | ||
- name: Export ENV Variables | ||
shell: bash | ||
working-directory: apollo-ios | ||
run: | | ||
apollo_ios_sha=$(git rev-parse HEAD) | ||
echo "APOLLO_IOS_SHA=$apollo_ios_sha" >> ${GITHUB_ENV} | ||
- name: Run CocoaPods Integration Tests | ||
id: run-cocoapods-integration-tests | ||
uses: ./.github/actions/run-cocoapods-integration-tests | ||
# CodegenTestConfigurations removed because source is not compatible with Sendable yet. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't mean to delete these. Will fix this before merging