-
-
Notifications
You must be signed in to change notification settings - Fork 57
chore(semantics): Remove determine_main #702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
59f9875 to
bf5852e
Compare
|
|
note that this is a subtle compatibility break with rules_python, at least last time I dug into this code, rules_python users couldn't adopt rules_py without changing their code. Perhaps we can make the case that we no longer aim for drop-in compatibility with rules_python, but if we give that up we ought to be clear about it in the readme or other communication with users. |
This is true; rules_python has already swapped |
|
Gonna just redo this by vendoring the |
6342788 to
edd42e1
Compare

Vendor
rules_python'sdetermine_mainand remove the need for a separatedetermine_maintarget which complicates exec properties.Replaces #641 with thanks to Keith.
Fixes #605
Fixes #621
Note that
py_venv_*already mandates that amain=label be provided, so this is for legacypy_binaryonly. Should be removed in 2.0.Changes are visible to end-users: no
Test plan