cmake: emit warning when failing to cross-compile #1438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmake requires setting CMAKE_SYSTEM_NAME to detect a cross-compile of any form (including same-os but different-processor). This means that, if an OS is not listed under _TARGET_OS_PARAMS, cross-compilation can never work on that platform; it would have silently done a native compile. This change makes it emit a warning in this case, and adds macos to the list so xcompiles work on macos.
jsharpe
reviewed
Oct 3, 2025
Comment on lines
+135
to
+136
| # buildifier: disable=print | ||
| print("target_os", target_os, "is not in _TARGET_OS_PARAMS, please update foreign_cc/private/cmake_script.bzl; triggered by", current_label) |
There was a problem hiding this comment.
Is there any reason not to actually fail() here?
There was a problem hiding this comment.
Nope, I just did it this way for parity with the checks above, but I can make it fail if you'd prefer that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmake requires setting CMAKE_SYSTEM_NAME to detect a cross-compile of any form (including same-os but different-processor). This means that, if an OS is not listed under _TARGET_OS_PARAMS, cross-compilation can never work on that platform; it would have silently done a native compile.
This change makes it emit a warning in this case, and adds macos to the list so xcompiles work on macos.