Skip to content

cmake: emit warning when failing to cross-compile #1438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

cmake: emit warning when failing to cross-compile #1438

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
230446f
cmake: emit warning when failing to cross-compile
novas0x2a Sep 2, 2025
dbb75b5
Merge branch 'main' into darwin-xcompile
novas0x2a Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions foreign_cc/private/cmake_script.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ _TARGET_OS_PARAMS = {
"linux": {
"CMAKE_SYSTEM_NAME": "Linux",
},
"macos": {
"CMAKE_SYSTEM_NAME": "Darwin",
},
}

_TARGET_ARCH_PARAMS = {
Expand Down Expand Up @@ -124,8 +127,19 @@ def create_cmake_script(
# buildifier: disable=print
print("target_arch is unknown, please update foreign_cc/private/framework/platform.bzl and foreign_cc/private/cmake_script.bzl; triggered by", current_label)
elif target_os != host_os or target_arch != host_arch:
toolchain_dict.update(_TARGET_OS_PARAMS.get(target_os, {}))
toolchain_dict.update(_TARGET_ARCH_PARAMS.get(target_arch, {}))
# if we don't have a value here, it will end up attempting a native
# compile, even if that's not right, so emit a warning
if target_os in _TARGET_OS_PARAMS:
toolchain_dict.update(_TARGET_OS_PARAMS[target_os])
else:
# buildifier: disable=print
print("target_os", target_os, "is not in _TARGET_OS_PARAMS, please update foreign_cc/private/cmake_script.bzl; triggered by", current_label)
Comment on lines +135 to +136
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason not to actually fail() here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, I just did it this way for parity with the checks above, but I can make it fail if you'd prefer that


if target_arch in _TARGET_ARCH_PARAMS:
toolchain_dict.update(_TARGET_ARCH_PARAMS[target_arch])
else:
# buildifier: disable=print
print("target_arch", target_arch, "is not in _TARGET_ARCH_PARAMS, please update foreign_cc/private/cmake_script.bzl; triggered by", current_label)

keys_with_empty_values_in_user_cache = [key for key in user_cache if user_cache.get(key) == ""]

Expand Down