Fix bash issues in osx_cc_wrapper.sh.tpl#685
Merged
fmeum merged 2 commits intobazel-contrib:masterfrom Feb 25, 2026
Merged
Conversation
fmeum
approved these changes
Feb 24, 2026
helly25
requested changes
Feb 24, 2026
Collaborator
helly25
left a comment
There was a problem hiding this comment.
The linter is unhappy. Just follow the instructions of the failed PR check.
Member
|
Please fix the lint finding |
f45c36a to
ba8e4fe
Compare
Contributor
Author
|
@helly25, I believe I've fixed the formatting issue. |
helly25
approved these changes
Feb 24, 2026
ba8e4fe to
1c6b1c2
Compare
fmeum
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues with the
osx_cc_wrapper.sh.tplandcc_wrapper.sh.tpltemplates:-r ${i:1}, which was checking the loop index value, not the argument that corresponds to the name of the parameter file. This was changed to-r ${!i:1}.osx_cc_wrapper.sh.tpl) The temporary file was being appended to with the result ofparse_option, which doesn't return any value, resulting in the tempfile being empty. This was changed to runparse_option "${opt}"separately from appending the option to the file, ensuring that the temporary file is being populated with the sanitized commands.The first fix addresses the issue of arguments in the param files not being sanitized, while the second addresses the issue of the sanitized arguments in the parameter file not being passed through.