Skip to content

Fix bash issues in osx_cc_wrapper.sh.tpl #685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fmeum merged 2 commits into from
Feb 25, 2026
+4 −3
Merged

Fix bash issues in osx_cc_wrapper.sh.tpl #685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1267877
Fix the condition for sanitizing parameter files
trevor-stripe Feb 24, 2026
1c6b1c2
Add sanitized commands to temporary command files
trevor-stripe Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion toolchain/cc_wrapper.sh.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ function sanitize_option() {

cmd=()
for ((i = 0; i <= $#; i++)); do
if [[ ${!i} == @* && -r "${i:1}" ]]; then
if [[ ${!i} == @* && -r "${!i:1}" ]]; then
# Create a new, sanitized file.
tmpfile=$(mktemp)
CLEANUP_FILES+=("${tmpfile}")
Expand Down
5 changes: 3 additions & 2 deletions toolchain/osx_cc_wrapper.sh.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,15 +146,16 @@ function sanitize_option() {

cmd=()
for ((i = 0; i <= $#; i++)); do
if [[ ${!i} == @* && -r "${i:1}" ]]; then
if [[ ${!i} == @* && -r "${!i:1}" ]]; then
tmpfile=$(mktemp)
CLEANUP_FILES+=("${tmpfile}")
while IFS= read -r opt; do
opt="$(
set -e
sanitize_option "${opt}"
)"
parse_option "${opt}" >>"${tmpfile}"
parse_option "${opt}"
echo "${opt}" >>"${tmpfile}"
done <"${!i:1}"
cmd+=("@${tmpfile}")
else
Expand Down