Initial open-sourcing of add_dep tool #1269
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sluongng
reviewed
Nov 22, 2024
| @@ -0,0 +1,68 @@ | |||
| load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library", "go_test") | |||
There was a problem hiding this comment.
Suggested change
| load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library", "go_test") | |
| load("@io_bazel_rules_go//go:def.bzl", "go_binary", "go_library") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See bazelbuild/bazel#4990
This is a lightly modified fork of the internal tool, with updates to e.g. use
bazelinstead ofblaze, and use the standard flags package, etc. I confirmed that it works on examples like bazelbuild/bazel#4990.One open question here is test coverage. The internal implementation has a suite of e2e integration tests that can be run manually. They set up a tiny bazel workspace, do a build that produces an add_dep error, and confirm that running the provided command fixes the build. I could look at externalizing those. It would be nicer to have something that could run on CI.