-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
Add Transform Helper methods #15200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Bayslak
wants to merge
11
commits into
bevyengine:main
Choose a base branch
from
Bayslak:feat/transform-helpers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+24
−2
Open
Add Transform Helper methods #15200
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
ad09225
add transform helper methods
Bayslak 8b516ce
fix documentation for pipeline
Bayslak e04c025
refactor method signature to accept velocity as Vec3
Bayslak daa87b9
fix pipeline error
Bayslak 7cab110
Merge remote-tracking branch 'upstream/main' into feat/transform-helpers
Bayslak 5c4228d
refactor signature of methods to accept single vec3
Bayslak 4a2c10c
updated summaries of functions
Bayslak a6a0473
Merge branch 'main' into feat/transform-helpers
Bayslak 8c0ec70
doc update
Bayslak 16467d3
fix typo
Bayslak a503dae
Make methods const
alice-i-cecile File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This name is way too verbose to me, I would just call this
translate_local
, matching the existingrotate_local
. Godot also hasTransform3D.translated_local
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the downside is that one could expect a "local translation" to also consider scale (Godot's does afaik), which
translate_with_local_rotation
shouldn't do.But idk I'd rather just manually do
transform.translate(transform.rotation * local_translation)
than use the long name and dotransform.translate_with_local_rotation(local_translation)
, but that's probably a me-problem 😅There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think my personal preference here would probably be having
translate
andtranslate_local
, where the latter is with respect to the local frame, considering both rotation and scale. If you only want to consider rotation, then you can just dotransform.translate(transform.rotation * local_translation)
.