Skip to content

Rename num_entities to entity_count #19781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2025
Merged

Rename num_entities to entity_count #19781

merged 1 commit into from
Jun 23, 2025

Conversation

mgi388
Copy link
Contributor

@mgi388 mgi388 commented Jun 23, 2025

As discussed in #19780 (comment).

@mgi388
Copy link
Contributor Author

mgi388 commented Jun 23, 2025

cc @Trashtalk217 friendly ping so you know the function was renamed if you go looking.

@mgi388 mgi388 requested a review from alice-i-cecile June 23, 2025 02:18
@mgi388 mgi388 added D-Trivial Nice and easy! A great choice to get started with Bevy A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jun 23, 2025
@alice-i-cecile alice-i-cecile added X-Contentious There are nontrivial implications that should be thought through S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed X-Contentious There are nontrivial implications that should be thought through S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jun 23, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 23, 2025
Merged via the queue into bevyengine:main with commit efd17f1 Jun 23, 2025
45 checks passed
@mgi388 mgi388 deleted the use-count-suffix1 branch June 23, 2025 05:28
Trashtalk217 pushed a commit to Trashtalk217/bevy that referenced this pull request Jul 10, 2025
@mgi388 @Trashtalk217
Rename num_entities to entity_count (bevyengine#19781)
b870a7e 
As discussed in
bevyengine#19780 (comment).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgi388 @alice-i-cecile