WIP: Fix glTF model forward direction #20135
Conversation
|
The generated |
| // With higher speed the curvature of the orbit would be smaller. | ||
| let incremental_turn_weight = cube.turn_speed * timer.delta_secs(); | ||
| let old_rotation = transform.rotation; | ||
| transform.rotation = old_rotation.lerp(look_at_sphere.rotation, incremental_turn_weight); |
There was a problem hiding this comment.
I believe this should be smooth_nudge nowadays
|
|
||
| /// Equivalent to [`-local_z()`][Transform::local_z] | ||
| #[inline] | ||
| pub fn forward(&self) -> Dir3 { |
There was a problem hiding this comment.
Should probably deprecate these methods instead of removing them
| /// Equivalent to [`-local_z()`][Transform::local_z] if `flip_model_forward` is false, | ||
| /// else [`local_z()`][Transform::local_z] | ||
| /// | ||
| /// glTF has opposing forward directions for cameras and lights, and for models. Model |
There was a problem hiding this comment.
To be asset agnostic, this should not even mention glTF imo
There was a problem hiding this comment.
If we decide to do this, we should only mention glTF in an explanatory note.
superdump
force-pushed
the
fix-gltf-model-forward
branch
from
fb2bcc4 to
aaa8f70
Compare
| translation: Vec3::from(translation), | ||
| rotation: bevy_math::Quat::from_array(rotation), | ||
| scale: Vec3::from(scale), | ||
| flip_model_forward: true, |
There was a problem hiding this comment.
Per @atlv24: let's make this a u8 enum :)
alice-i-cecile
added
X-Uncontroversial
| /// Equivalent to [`-local_z()`][Transform::local_z] | ||
| #[inline] | ||
| pub fn forward(&self) -> Dir3 { | ||
| pub fn camera_forward(&self) -> Dir3 { |
There was a problem hiding this comment.
This needs to cover lights too. Maybe just duplicate methods?
janhohenheim
added
the
M-Needs-Migration-Guide
|
It looks like your PR is a breaking change, but you didn't provide a migration guide. Please review the instructions for writing migration guides, then expand or revise the content in the migration guides directory to reflect your changes. |
alice-i-cecile
added
S-Needs-SME
|
Punted on for now due to concerns about how this would interact in cases such as global transform propagation and setting one transform equal to another. |
This is to illustrate what I think is needed for the glTF model forward direction being +z.