Skip to content

stop exposing minimp3 #20183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 20, 2025
Merged

stop exposing minimp3 #20183

merged 4 commits into from
Jul 20, 2025

Conversation

@mockersf
Copy link
Member

Objective

Solution

  • Stop exposing rodio support of mp3 through minimp3. rodio defaults to symphonia for mp3 now. People who really want an unsecured way to play mp3 that doesn't work in wasm and will get their app rejected from the iOS App Store can still enable it manually by adding a dependency on rodio

@mockersf mockersf added A-Audio Sounds playback and modification C-Dependencies A change to the crates that Bevy depends on labels Jul 17, 2025
@alice-i-cecile alice-i-cecile added the S-Needs-Review Needs reviewer attention (from anyone!) to move forward label Jul 17, 2025
tim-blackbird
tim-blackbird approved these changes Jul 17, 2025
View reviewed changes
Copy link
Contributor

@tim-blackbird tim-blackbird left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some digging into this a few days ago when I noticed the CI error, and I think this is a fair decision :)

@janhohenheim janhohenheim added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 17, 2025
@alice-i-cecile alice-i-cecile added this to the 0.17 milestone Jul 17, 2025
@alice-i-cecile alice-i-cecile added M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged and removed S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Jul 17, 2025
@github-actions
Copy link
Contributor

It looks like your PR is a breaking change, but you didn't provide a migration guide.

Please review the instructions for writing migration guides, then expand or revise the content in the migration guides directory to reflect your changes.

@alice-i-cecile
Copy link
Member

I'll merge this once there's a migration guide. Up to you what that should contain.

@mockersf mockersf added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Jul 19, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jul 20, 2025
Merged via the queue into bevyengine:main with commit 606c6b5 Jul 20, 2025
36 checks passed
@github-project-automation github-project-automation bot moved this to Done in Audio Jul 20, 2025
@alice-i-cecile alice-i-cecile mentioned this pull request Oct 29, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

+2 more reviewers

@kristoff3r kristoff3r kristoff3r approved these changes

@tim-blackbird tim-blackbird tim-blackbird approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Audio Sounds playback and modification C-Dependencies A change to the crates that Bevy depends on M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Audio
Status: Done

Milestone

0.17

Development

Successfully merging this pull request may close these issues.

check-advisories CI is complaining about slice-ring-buffer 0.3.4

5 participants

@mockersf @alice-i-cecile @kristoff3r @tim-blackbird @janhohenheim