Use RenderStartup
for CopyDeferredLightingIdPipeline
.
#20195
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
xvfb-run
atexit
handlers) while we are also compiling pipelines in parallel. It seems LLVM code is not quite multithread safe in this situation.Solution
Most of this is the same as all the other
RenderStartup
migrations.In addition, I had to 1) enable synchronous pipeline compilation, 2) disable pipelined rendering in the
ambiguity_detection
test. This ensures that 1) the render thread just blocks on pipeline compilation rather than letting it run in another thread, 2) we don't leaveApp::update
until the render thread finishes. So therefore, there won't be any pipeline compilation happening by the time the test ends.Testing