Skip to content

Clean up NodeId kind fetching #20196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 21, 2025
Merged

Clean up NodeId kind fetching #20196

merged 2 commits into from
Jul 21, 2025
+52 −43

Conversation

ItsDoot
Copy link
Contributor

@ItsDoot ItsDoot commented Jul 19, 2025

Objective

We don't actually need the ScheduleGraph in order to get the kind of a node, so lets move it to our newly created trait.

Solution

  • Removed ScheduleGraph::get_node_kind, added GraphNodeId::kind instead.
  • Co-located GraphNodeId in the same file as DiGraph/UnGraph/Graph.
  • Implemented GraphNodeId for SystemSetKey for symmetry.

No migration guide needed as get_node_kind is a private function.

Testing

Re-using current tests.

@ItsDoot ItsDoot added D-Trivial Nice and easy! A great choice to get started with Bevy A-ECS Entities, components, systems, and events D-Domain-Agnostic Can be tackled by anyone with generic programming or Rust skills S-Needs-Review Needs reviewer attention (from anyone!) to move forward C-Code-Quality A section of code that is hard to understand or change labels Jul 19, 2025
@ItsDoot ItsDoot mentioned this pull request Jul 17, 2025
Open
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 19, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jul 21, 2025
Merged via the queue into bevyengine:main with commit 2b3ee67 Jul 21, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@hymm hymm Awaiting requested review from hymm

+1 more reviewer

@chescock chescock chescock approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change D-Domain-Agnostic Can be tackled by anyone with generic programming or Rust skills D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ItsDoot @alice-i-cecile @chescock