Skip to content

Adjust benches to be more robust #20207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 20, 2025
Merged

Adjust benches to be more robust #20207

merged 2 commits into from
Jul 20, 2025

Conversation

Trashtalk217
Copy link
Contributor

@Trashtalk217 Trashtalk217 commented Jul 19, 2025 •
edited
Loading

Objective

Currently, benchmarks access the world's entities in a very unsafe way, which doesn't hold up if we add more internal entities.

Part of #19711.

Solution

Have the setups return a Vec<Entity> we can iterate over.

Testing

Not needed.

@Trashtalk217 Trashtalk217 added D-Trivial Nice and easy! A great choice to get started with Bevy C-Benchmarks Stress tests and benchmarks used to measure how fast things are labels Jul 19, 2025
@Trashtalk217 Trashtalk217 added C-Code-Quality A section of code that is hard to understand or change S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jul 19, 2025
@mockersf mockersf added this pull request to the merge queue Jul 20, 2025
Merged via the queue into bevyengine:main with commit 6354a95 Jul 20, 2025
36 checks passed
@Trashtalk217 Trashtalk217 mentioned this pull request Jul 24, 2025
Open
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mockersf mockersf mockersf approved these changes

@ElliottjPierce ElliottjPierce Awaiting requested review from ElliottjPierce

+1 more reviewer

@chescock chescock chescock approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
C-Benchmarks Stress tests and benchmarks used to measure how fast things are C-Code-Quality A section of code that is hard to understand or change D-Trivial Nice and easy! A great choice to get started with Bevy S-Needs-Review Needs reviewer attention (from anyone!) to move forward
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Trashtalk217 @chescock @mockersf