Skip to content

Conversation

atlv24
Copy link
Contributor

@atlv24 atlv24 commented Aug 25, 2025

Objective

Solution

  • copy paste the morph weights stuff out into a module, gate it, then add the optional dep

@alice-i-cecile alice-i-cecile added C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Animation Make things move and change over time M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Aug 25, 2025
@atlv24 atlv24 force-pushed the ad/meshless-animate branch from e26c392 to 4ceea29 Compare August 28, 2025 02:08
@greeble-dev greeble-dev added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Aug 31, 2025
@greeble-dev
Copy link
Contributor

I'm not sure M-Needs-Migration-Guide applies - change is backwards compatible with use bevy::animation::animation_curves::WeightsCurve and preludes.

@atlv24
Copy link
Contributor Author

atlv24 commented Sep 1, 2025

Migration guide is indeed not needed here.

@mockersf
Copy link
Member

mockersf commented Sep 1, 2025

Shouldn't there be a morph_weights feature that enables bevy_mesh? It feels a bit backward to do it the other way.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Sep 1, 2025
@alice-i-cecile alice-i-cecile removed this pull request from the merge queue due to a manual request Sep 1, 2025
@alice-i-cecile alice-i-cecile added S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged and removed S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Sep 1, 2025
@alice-i-cecile
Copy link
Member

Shouldn't there be a morph_weights feature that enables bevy_mesh? It feels a bit backward to do it the other way.

This feels clearer to me too.

@atlv24
Copy link
Contributor Author

atlv24 commented Sep 2, 2025

I think that's an orthogonal request: bevy_mesh does not have a morph_weights feature. If it did, it would make sense to gate this on bevy_mesh/morph_weights, but right now this is about bevy_animation supporting bevy_mesh. The specific part of bevy_mesh it supports is morph weights, but this could just as easily be gating skinning code or other things.

@atlv24
Copy link
Contributor Author

atlv24 commented Sep 2, 2025

I'd be in favor of adding a morph_weights feature to bevy_mesh which gates it there and also in bevy_animate, anyhow. I just dont think its relevant to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Animation Make things move and change over time C-Usability A targeted quality-of-life change that makes Bevy easier to use M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants