Skip to content

bevy_text::input module with no undo #20763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 99 commits into
base: main
Choose a base branch
from
Open

bevy_text::input module with no undo #20763

wants to merge 99 commits into from
+1,806 −14

Conversation

Zeophlite
Copy link
Contributor

@Zeophlite Zeophlite commented Aug 26, 2025 •
edited
Loading

Objective

Testing

  • CI

ickshonpe and others added 30 commits July 30, 2025 18:25
@ickshonpe
Added input module to bevy_text with systems and components to su…
edc879c 
…pport text editing.
@ickshonpe
use is_empty() instead of checking lengeth is 0
f36f9d0
@ickshonpe
Renamings:
771477c 
* `TextInputAction` -> `TextEdit`
* `TextInputActions` -> `TextEdits`
@ickshonpe
Renamed TextInputPasswordMask to PasswordMask
11074c0
@ickshonpe
Updated comments including suggestions from review
f991426
@ickshonpe
Added a TextEdit::InsertString variant. Use to insert a string at t…
62ca2f8 
…he cursor. If there is a selection, overwrites it instead.
@ickshonpe
Renamed appy_text_input_action to apply_text_edit
308d0c9
@ickshonpe
Updated TextInputValue's comments to explain that it is synchronise…
158f329 
…d automatically with the `TextInputValue `text
@ickshonpe
Expanded the doc comments for TextInputAttributes.
a7d5e45
@ickshonpe
Renamed TextInputUndoHistory to UndoHistory
785a1d5
@ickshonpe
Merge branch 'main' into bevy-text-input
f637123
@ickshonpe
Updated buffer's docs and added a needs_redraw function.
b4589b8
@ickshonpe
Updated the doc comments for apply_text_edits
8e61105
@ickshonpe
updated another doc comment
ede9d60
@ickshonpe
More doc comments
a80a5dc
@ickshonpe
Edited the doc comment for apply_text_edits
0b2c268
@ickshonpe
More comment edits
93149bc
@ickshonpe
Renamed Prompt to Placeholder and also updated the comments and t…
049e350 
…he associated types and systems.
@ickshonpe
Fixed renaming.
3e9c860
@ickshonpe
Rephrased doc comment.
5c956c6
@ickshonpe
Spellings.
6396a11
@ickshonpe
Renamed the InvalidInput and ValueChanged TextInputEvent varian…
5d34e6d 
…ts to `InvalidEdit` and `TextChanged` respectively.
@ickshonpe
Fixed event dispatch.
57a70cd
@ickshonpe
Added release note
85bed33
@ickshonpe
Added migration note for load_font_to_fontdb function changes.
f43c461
@ickshonpe
Update release note
0b6b1d2
@ickshonpe
Merge branch 'main' into bevy-text-input
897d741
@ickshonpe @tim-blackbird
Update crates/bevy_text/src/input.rs
2bd0216 
Co-authored-by: Tim <[email protected]>
@ickshonpe @tim-blackbird
Update crates/bevy_text/src/input.rs
255d2c1 
Co-authored-by: Tim <[email protected]>
@ickshonpe @tim-blackbird
Update crates/bevy_text/src/input.rs
419bcaf 
Co-authored-by: Tim <[email protected]>
@tigregalis
Copy link
Contributor

Hey @tigregalis , I think the below addresses your feedback for this release, and the rest can be deferred for another PR?

Yeah, sounds good.

I am a little hesitant about the password mask and the input filter being part of the same PR, but if those are the features people are looking for ultimately, maybe it doesn't make sense to hold them back for the sake of code history/evolution clarity.

atlv24
atlv24 reviewed Aug 30, 2025
View reviewed changes
atlv24
atlv24 reviewed Aug 30, 2025
View reviewed changes
atlv24
atlv24 reviewed Aug 30, 2025
View reviewed changes
Copy link
Contributor

@atlv24 atlv24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am concerned about how much code is in the example. additionally, it seems this is just for 2d, can it be used in a ui in 3d or etc easily?

@Zeophlite
Copy link
Contributor Author

i am concerned about how much code is in the example. additionally, it seems this is just for 2d, can it be used in a ui in 3d or etc easily?

There's a lot in the example as this is the "low level" api - the follow-up PR has the "mid level" api for widgets, etc. Have a look at the examples/ in https://github.com/bevyengine/bevy/pull/20326/files .

mockersf
mockersf requested changes Aug 30, 2025
View reviewed changes
Copy link
Member

@mockersf mockersf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've played a bit with this PR and how to use it, and I think it introduces too many things at once, and some that doesn't interact well together.

I would prefer a simpler PR that would introduce a component that holds a cosmic buffer, and how to interact with it. Making it smaller would also improve the code organisation.

I don't think this should be merged in this state.

@Zeophlite
Copy link
Contributor Author

and some that doesn't interact well together

@mockersf Could you expand on this point?

@alice-i-cecile alice-i-cecile added S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Sep 1, 2025
@alice-i-cecile alice-i-cecile modified the milestones: 0.17, 0.18 Sep 1, 2025
@Zeophlite
Copy link
Contributor Author

I've taken the time to split up input.rs

@Zeophlite Zeophlite mentioned this pull request Sep 2, 2025
Draft
@Zeophlite
Copy link
Contributor Author

Zeophlite commented Sep 2, 2025 •
edited
Loading

I have also taken the time to adopt #20326 , rebase onto this branch - see #20826

This was very helpful in fleshing out some concepts, such as "submit"

I appreciate any feedback on either repo on what parts should be pulled out to help merge these

@Zeophlite
Copy link
Contributor Author

This version has removed clipboard, filtering, masking, they will be re-added as separate PRs

@Zeophlite Zeophlite mentioned this pull request Sep 5, 2025
Open
@Zeophlite Zeophlite added S-Needs-Review Needs reviewer attention (from anyone!) to move forward and removed S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cart cart cart left review comments

@alice-i-cecile alice-i-cecile alice-i-cecile requested changes

@mockersf mockersf mockersf requested changes

+2 more reviewers

@viridia viridia viridia approved these changes

@atlv24 atlv24 atlv24 left review comments

Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
A-Text Rendering and layout for characters A-UI Graphical user interfaces, styles, layouts, and widgets C-Feature A new feature, making something new possible M-Needs-Release-Note Work that should be called out in the blog due to impact S-Needs-Review Needs reviewer attention (from anyone!) to move forward X-Contentious There are nontrivial implications that should be thought through
Projects
None yet
Milestone
0.18
Development

Successfully merging this pull request may close these issues.
8 participants
@Zeophlite @mockersf @viridia @tigregalis @cart @alice-i-cecile @atlv24 @ickshonpe