Skip to content

partition miri tests #20818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

partition miri tests #20818

wants to merge 7 commits into from
+32 −2

Conversation

mockersf
Copy link
Member

@mockersf mockersf commented Sep 1, 2025

Objective

  • speed up CI

Solution

Testing

  • running CI on this PR

@mockersf mockersf added the A-Build-System Related to build systems or continuous integration label Sep 1, 2025
IceSentry
IceSentry reviewed Sep 1, 2025
View reviewed changes
IceSentry
IceSentry approved these changes Sep 1, 2025
View reviewed changes
Copy link
Contributor

@IceSentry IceSentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what's the issue with CI but the partitioning stuff LGTM

@mockersf
Copy link
Member Author

mockersf commented Sep 1, 2025 •
edited
Loading

Not sure what's the issue with CI

It was me forgetting this job runs on macos and getting the linux bin

@mockersf
Copy link
Member Author

mockersf commented Sep 1, 2025

miri is a lot slower running under nextest in CI...

@mockersf mockersf force-pushed the partition-miri-tests branch from 61fa018 to d70480b Compare September 1, 2025 18:35
@mockersf
Copy link
Member Author

mockersf commented Sep 1, 2025

well it's faster if I do 50 partitions 😄

@mockersf mockersf force-pushed the partition-miri-tests branch from 53b15bb to de1db0a Compare September 1, 2025 19:04
@mockersf
Copy link
Member Author

mockersf commented Sep 1, 2025

not sure this is a good idea... with 20 partitions miri is no longer the longest job in CI, but the longest partition still takes 15 minutes.

somehow it's a lot slower when running through nextest

@mockersf mockersf requested a review from IceSentry September 1, 2025 19:25
IceSentry
IceSentry approved these changes Sep 1, 2025
View reviewed changes
Copy link
Contributor

@IceSentry IceSentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess faster is faster 😅 but it does feel a bit weird that this would need that many partitions.

@alice-i-cecile alice-i-cecile added C-Performance A change motivated by improving speed, memory usage or compile times S-Needs-Help The author needs help finishing this PR. labels Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@IceSentry IceSentry IceSentry approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration C-Performance A change motivated by improving speed, memory usage or compile times S-Needs-Help The author needs help finishing this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mockersf @IceSentry @alice-i-cecile