Skip to content
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 31 additions & 2 deletions crates/bevy_camera/src/visibility/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -679,8 +679,14 @@ pub fn add_visibility_class<C>(
) where
C: 'static,
{
if let Some(mut visibility_class) = world.get_mut::<VisibilityClass>(entity) {
visibility_class.push(TypeId::of::<C>());
let Some(mut visibility_class) = world.get_mut::<VisibilityClass>(entity) else {
// potentially warn in this case?
return;
};

let type_id = TypeId::of::<C>();
if !visibility_class.contains(&type_id) {
visibility_class.push(type_id);
}
}

Expand Down Expand Up @@ -988,4 +994,27 @@ mod test {
assert_eq!(1, size_of::<Visibility>());
assert_eq!(1, size_of::<Option<Visibility>>());
}

#[derive(Component, Default, Clone, Reflect)]
#[require(VisibilityClass)]
#[reflect(Component, Default, Clone)]
#[component(on_add = add_visibility_class::<Self>)]
struct TestVisibilityClassHook;

#[test]
fn test_add_visibility_class_hook() {
let mut world = World::new();
let entity = world.spawn(TestVisibilityClassHook).id();
let entity_clone = world.spawn_empty().id();
world
.entity_mut(entity)
.clone_with_opt_out(entity_clone, |_| {});

let entity_visibility_class = world.entity(entity).get::<VisibilityClass>().unwrap();
assert_eq!(entity_visibility_class.len(), 1);

let entity_clone_visibility_class =
world.entity(entity_clone).get::<VisibilityClass>().unwrap();
assert_eq!(entity_clone_visibility_class.len(), 1);
}
}
Loading