[Merged by Bors] - Expose set_changed() on ResMut and Mut #2208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanSWard
added
A-ECS
Yep! That was part of the inspiration behind #2189, which you may find useful. |
alice-i-cecile
approved these changes
May 18, 2021
alice-i-cecile
added
the
S-Ready-For-Final-Review
mockersf
approved these changes
May 18, 2021
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 18, 2021
This new api stems from this [discord conversation](https://discord.com/channels/691052431525675048/742569353878437978/844057268172357663). This exposes a public facing `set_changed` method on `ResMut` and `Mut`. As a side note: `ResMut` and `Mut` have a lot of duplicated code, I have a PR I may put up later that refactors these commonalities into a trait. Co-authored-by: Carter Anderson <[email protected]>
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
ostwilkens
pushed a commit
to ostwilkens/bevy
that referenced
this pull request
Jul 27, 2021
This new api stems from this [discord conversation](https://discord.com/channels/691052431525675048/742569353878437978/844057268172357663). This exposes a public facing `set_changed` method on `ResMut` and `Mut`. As a side note: `ResMut` and `Mut` have a lot of duplicated code, I have a PR I may put up later that refactors these commonalities into a trait. Co-authored-by: Carter Anderson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new api stems from this discord conversation.
This exposes a public facing
set_changedmethod onResMutandMut.As a side note:
ResMutandMuthave a lot of duplicated code, I have a PR I may put up later that refactors these commonalities into a trait.