Skip to content

Add smol_str feature to bevy_reflect dependency for bevy_text.#22848

Open
andriyDev wants to merge 1 commit intobevyengine:mainfrom
andriyDev:smol_str-fix
Open

Add smol_str feature to bevy_reflect dependency for bevy_text.#22848
andriyDev wants to merge 1 commit intobevyengine:mainfrom
andriyDev:smol_str-fix

Conversation

@andriyDev
Copy link
Contributor

Objective

  • cargo b -p bevy_text fails to compile due to missing Reflect impl on SmolStr.

Solution

  • Add the smol_str feature to bevy_texts bevy_reflect dependency.

Testing

  • cargo b -p bevy_text fails to compile on main, but it succeeds with this PR.

@andriyDev andriyDev added C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy A-Build-System Related to build systems or continuous integration S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Feb 7, 2026
@kfc35
Copy link
Contributor

kfc35 commented Feb 7, 2026

This looks related to proposed solutions in #22497 just fyi

@mnmaita
Copy link
Member

mnmaita commented Feb 7, 2026

Oh! Thanks for the heads up, I'll check if this also fixes the common_api build issue and close my PR if so.

@mnmaita mnmaita added the P-Compile-Failure A failure to compile Bevy apps label Feb 7, 2026
Copy link
Member

@mnmaita mnmaita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works and also fixes #22497, thanks!

@mnmaita mnmaita added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Feb 7, 2026
@kfc35 kfc35 added this to the 0.18.1 milestone Feb 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Build-System Related to build systems or continuous integration C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy P-Compile-Failure A failure to compile Bevy apps S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants