Add smol_str feature to bevy_reflect dependency for bevy_text.#22848
Open
andriyDev wants to merge 1 commit intobevyengine:mainfrom
Open
Add smol_str feature to bevy_reflect dependency for bevy_text.#22848andriyDev wants to merge 1 commit intobevyengine:mainfrom
andriyDev wants to merge 1 commit intobevyengine:mainfrom
Conversation
Contributor
|
This looks related to proposed solutions in #22497 just fyi |
Member
|
Oh! Thanks for the heads up, I'll check if this also fixes the |
46fc085 to
82807ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
cargo b -p bevy_textfails to compile due to missingReflectimpl onSmolStr.Solution
smol_strfeature tobevy_textsbevy_reflectdependency.Testing
cargo b -p bevy_textfails to compile on main, but it succeeds with this PR.