util.countnans: Don't treat single-row sparse matrices as 1-d #7219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janezd
force-pushed
the
countnans-sparse
branch
from
05fc4e7 to
ac09b43
Compare
janezd
force-pushed
the
countnans-sparse
branch
from
ac09b43 to
8662f0f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7219 +/- ##
=======================================
Coverage 89.03% 89.03%
=======================================
Files 335 335
Lines 74243 74245 +2
=======================================
+ Hits 66100 66103 +3
+ Misses 8143 8142 -1 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes #7164.
Description of changes
countnanstreats a sparse matrix of shape (1, n) as a vector. Using @pavlin-policar 's trick, we transpose it. (Besides being the inventor of the trick, he also caused this trick to be needed.)Includes