Skip to content

util.countnans: Don't treat single-row sparse matrices as 1-d #7219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
VesnaT merged 1 commit into from
Jan 9, 2026
+12 −1
Merged

util.countnans: Don't treat single-row sparse matrices as 1-d #7219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Orange/statistics/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,12 @@ def stats(X, weights=None, compute_variance=False):

if X.size and is_numeric:
if is_sparse:
nans = countnans(X, axis=0)
if X.shape[0] == 1:
# Since `countnans` assumes vector shape to be (1, n) and `x`
# shape is (n, 1), we pass the transpose
nans = countnans(X.T, axis=1)
else:
nans = countnans(X, axis=0)
X = X.tocsc()
else:
nans = np.isnan(X).sum(axis=0)
Expand Down
6 changes: 6 additions & 0 deletions Orange/widgets/data/tests/test_owtable.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,12 @@ def test_input_data_empty(self):
output = self.get_output(self.widget.Outputs.annotated_data)
self.assertIsNone(output)

def test_data_single_sparse(self):
data = self.data[:1].to_sparse()
self.send_signal(self.widget.Inputs.data, data)
self.assertIs(self.widget.input.table, data)
self.assertIs(self.widget.view.model().source, data)

def test_data_model(self):
self.send_signal(self.widget.Inputs.data, self.data)
self.assertEqual(self.widget.view.model().rowCount(), len(self.data))
Expand Down