Add shared block explorer presets

[praveenperera]

Summary

• Add Rust-owned block explorer preset options for mempool.guide, Bull Bitcoin mempool, Blockstream, Custom, and the default mempool.space explorer
• Expose the preset list and selected option through UniFFI so iOS and Android share the same explorer catalog and selection behavior
• Add settings UI copy explaining block explorers and show preset options before the custom URL/template editor

Validation

• just fmt
• cargo test block_explorer --lib
• just clippy
• just build-ios
• just build-android
• just compile-ios
• just compile-android
• just lint-android
• git diff --check

Summary by CodeRabbit

• New Features

  • Added selectable block explorer options, including custom URL/template support, with clearer save/reset flows and success feedback.
  • Improved block explorer URL handling across the app for more reliable previews and matching.
  • Enabled local network access on iOS for connecting to explorers and nodes.

• Bug Fixes

  • Prevented duplicate updates when reselecting the same node preset.
  • Improved network request reliability in CI by reducing Cargo transport issues.

• UI Improvements

  • Updated settings screens to better separate preset options from custom explorer input.
  • Simplified the block explorer entry in General settings.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a9e7e86d-dc6c-4dd2-8e4c-48dd193bdc5f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch other-mempools

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[greptile-apps]

Greptile Summary

This PR adds a curated list of block explorer presets (mempool.space, mempool.guide, Bull Bitcoin, Blockstream, Custom) shared across iOS and Android via UniFFI. It also refactors the template parsing into a dedicated module, adds scheme inference for local/IP addresses, and updates the settings UI to show a picker before the custom URL editor.

• Rust core: BlockExplorerOption enum with preset definitions, matching_stored_template for round-tripping selections, set_block_explorer_option for saving presets, and all_block_explorer_options() exported via UniFFI.
• Template module: Extracted and enhanced with domain validation, .local/IP scheme inference, and improved known-host matching; PREVIEW_TXID updated to the genesis coinbase transaction.
• iOS/Android UI: Settings screens now show a radio-style preset list followed by the custom URL editor (only visible when Custom is selected); preset saves are synchronous while custom URL saves are async with a loading indicator (Android) or success popup (iOS).

Confidence Score: 5/5

Safe to merge; the two findings are cosmetic UX nits that don't affect data integrity or stored state.

The Rust core changes are well-tested, the UniFFI surface is consistent with existing patterns, and no stored data is at risk. The two flagged issues — unconditional input clearing when re-tapping an already-selected Custom option, and synchronous DB calls in savePreset on the main thread — are both minor quality concerns that don't cause incorrect persisted state or crashes.

The select(.custom) path in both BlockExplorerSettingsView.swift and BlockExplorerSettingsScreen.kt clears the text field even when Custom is already the active selection.

Important Files Changed

Filename	Overview
rust/src/custom_block_explorer.rs	Introduces BlockExplorerOption enum with preset definitions, matching logic, and UniFFI-exported helpers; old template code moved to template.rs. Logic is sound and well-tested.
rust/src/custom_block_explorer/template.rs	New module holding the template parsing logic refactored from the old custom_block_explorer.rs, with enhanced host validation, scheme inference for local/IP inputs, and a comprehensive test suite.
rust/src/database/global_config.rs	Adds selected_block_explorer_option and set_block_explorer_option, removes effective_block_explorer_host; preset arm uses expect() on base_url (pre-existing concern noted in prior review threads).
ios/Cove/Flows/SettingsFlow/BlockExplorerSettingsView.swift	Replaces free-text-only editor with a preset picker plus a conditional Custom section; select(.custom) unconditionally clears input even when Custom is already selected, discarding unsaved input.
android/app/src/main/java/org/bitcoinppl/cove/flows/SettingsFlow/BlockExplorerSettingsScreen.kt	Adds preset list UI and async save; savePreset() calls DB operations on the main thread while save() correctly uses withContext(Dispatchers.IO), creating an inconsistency.
ios/Cove/Info.plist	Adds NSAllowsLocalNetworking and NSLocalNetworkUsageDescription to support custom explorers on .local hostnames and local IP addresses.
.github/workflows/ci.yml	Adds CARGO_HTTP_MULTIPLEXING=false and CARGO_NET_RETRY=10 env vars to improve reliability of cargo dependency fetching in CI.

Sequence Diagram

%%{init: {'theme': 'neutral'}}%%
sequenceDiagram
    participant UI as Settings UI (iOS/Android)
    participant Rust as Rust (UniFFI)
    participant DB as Database

    Note over UI,DB: Selecting a preset (non-Custom)
    UI->>Rust: setBlockExplorerOption(network, option)
    Rust->>DB: clear OR set custom template
    DB-->>Rust: ok
    Rust-->>UI: normalized template string?
    UI->>Rust: effectiveBlockExplorerPreview(network)
    Rust-->>UI: preview URL
    UI->>Rust: selectedBlockExplorerOption(network)
    Rust-->>UI: BlockExplorerOption

    Note over UI,DB: Selecting Custom (local state only, no DB write)
    UI->>UI: "selectedOption = .custom, input = """

    Note over UI,DB: Saving a custom URL
    UI->>Rust: setCustomBlockExplorer(network, input)
    Rust->>DB: store template
    DB-->>Rust: ok
    Rust-->>UI: normalized template
    UI->>Rust: effectiveBlockExplorerPreview(network)
    Rust-->>UI: preview URL
    UI->>Rust: selectedBlockExplorerOption(network)
    Rust-->>UI: BlockExplorerOption (.custom)

Loading

%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
sequenceDiagram
    participant UI as Settings UI (iOS/Android)
    participant Rust as Rust (UniFFI)
    participant DB as Database

    Note over UI,DB: Selecting a preset (non-Custom)
    UI->>Rust: setBlockExplorerOption(network, option)
    Rust->>DB: clear OR set custom template
    DB-->>Rust: ok
    Rust-->>UI: normalized template string?
    UI->>Rust: effectiveBlockExplorerPreview(network)
    Rust-->>UI: preview URL
    UI->>Rust: selectedBlockExplorerOption(network)
    Rust-->>UI: BlockExplorerOption

    Note over UI,DB: Selecting Custom (local state only, no DB write)
    UI->>UI: "selectedOption = .custom, input = """

    Note over UI,DB: Saving a custom URL
    UI->>Rust: setCustomBlockExplorer(network, input)
    Rust->>DB: store template
    DB-->>Rust: ok
    Rust-->>UI: normalized template
    UI->>Rust: effectiveBlockExplorerPreview(network)
    Rust-->>UI: preview URL
    UI->>Rust: selectedBlockExplorerOption(network)
    Rust-->>UI: BlockExplorerOption (.custom)

Loading

_{Reviews (2): Last reviewed commit: "Match preset block explorers explicitly" | Re-trigger Greptile}

[coderabbitai]

Actionable comments posted: 6

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@android/app/src/main/java/org/bitcoinppl/cove/flows/SettingsFlow/BlockExplorerSettingsScreen.kt`:
- Around line 131-134: The block explorer persistence call in
BlockExplorerSettingsScreen should stay on the caller coroutine thread instead
of hopping to Dispatchers.IO. Update the logic around
config.setCustomBlockExplorer inside the relevant save flow to invoke the Rust
FFI call directly, and keep the surrounding coroutine handling unchanged so the
function still captures the returned result normally.
- Around line 170-176: The selectOption function in BlockExplorerSettingsScreen
should not reset the custom explorer input when CUSTOM is tapped while it is
already selected. Update the BlockExplorerOption.CUSTOM branch in selectOption
to return early if selectedOption is already CUSTOM, so the existing input and
preview remain unchanged; otherwise keep the existing behavior for switching to
CUSTOM.

In
`@android/app/src/main/java/org/bitcoinppl/cove/flows/SettingsFlow/NodeSettingsScreen.kt`:
- Around line 136-138: The early return in the node selection handler is
comparing only selectedNodeName, which can incorrectly block a real change when
a custom node shares a name with a preset. Update the guard in
NodeSettingsScreen’s selection logic to compare the actual selected node state,
using both selectedNodeName and selectedNodeSelection (or the full selection
identity) before returning, so a preset can still be selected when the name
matches but the selection type differs.

In `@ios/Cove/Flows/SettingsFlow/BlockExplorerSettingsView.swift`:
- Around line 123-128: The select(_:) handler in BlockExplorerSettingsView is
clearing the custom editor even when .custom is already selected. Update the
BlockExplorerOption switching logic to return early if the tapped option matches
the current selectedOption, and only reset input/updatePreview when changing
into the custom option from a different selection. Keep the fix localized to
select(_:) so saved custom templates are preserved when re-tapping the Custom
row.

In `@rust/src/custom_block_explorer.rs`:
- Around line 73-80: The default label returned by as_display_name is
provider-specific, but MempoolSpace is only the default option and may not map
to mempool.space on all networks. Update the MempoolSpace match arm in
custom_block_explorer::as_display_name to use a provider-neutral label such as
“Default explorer”, or make it network-aware if the display name should reflect
the active template.

In `@rust/src/custom_block_explorer/template.rs`:
- Around line 326-333: The known_host_network_prefix mapping in template.rs only
handles mempool.space and mutinynet.com, so BlockExplorerOption::base_url() ->
from_base_url() can drop the network segment for new multi-network presets like
Blockstream on Testnet. Extend the prefix table to cover provider-specific
non-Bitcoin network prefixes for the new presets, or make unsupported
preset/network combinations fail explicitly in the same flow, and add tests that
verify non-Bitcoin canonicalization for the affected BlockExplorerOption
variants.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: cf6fb8f8-8d01-45f8-bdc8-04252ce7ece2

📥 Commits

Reviewing files that changed from the base of the PR and between b0ce973 and b24630a.

⛔ Files ignored due to path filters (2)

• android/app/src/main/java/org/bitcoinppl/cove_core/cove.kt is excluded by !android/app/src/main/java/org/bitcoinppl/cove_core/**
• ios/CoveCore/Sources/CoveCore/generated/cove.swift is excluded by !**/generated/**, !ios/CoveCore/Sources/CoveCore/generated/**

📒 Files selected for processing (12)

• .github/workflows/ci.yml
• android/app/src/main/java/org/bitcoinppl/cove/flows/SettingsFlow/BlockExplorerSettingsScreen.kt
• android/app/src/main/java/org/bitcoinppl/cove/flows/SettingsFlow/MainSettingsScreen.kt
• android/app/src/main/java/org/bitcoinppl/cove/flows/SettingsFlow/NodeSettingsScreen.kt
• android/app/src/main/res/values/strings.xml
• ios/Cove/Flows/SettingsFlow/BlockExplorerSettingsView.swift
• ios/Cove/Flows/SettingsFlow/MainSettingsScreen.swift
• ios/Cove/Info.plist
• ios/Cove/Views/MiddlePopupView.swift
• rust/src/custom_block_explorer.rs
• rust/src/custom_block_explorer/template.rs
• rust/src/database/global_config.rs

💤 Files with no reviewable changes (1)

• android/app/src/main/java/org/bitcoinppl/cove/flows/SettingsFlow/MainSettingsScreen.kt