MB-71397: Fix size calculation for FAISS Indexes#62
Open
CascadingRadium wants to merge 7 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Go FAISS bindings to use the newer FAISS C API signatures for retrieving index size, so Size() continues to work with updated FAISS versions.
Changes:
- Switch
faiss_Index_sizebinding usage to the new(index, *size_t) -> intform and handle the return code. - Switch
faiss_IndexBinary_sizebinding usage to the new(index, *size_t) -> intform and handle the return code.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| index.go | Updates Index.Size() to call the new faiss_Index_size signature using an out-parameter. |
| index_binary.go | Updates BinaryIndex.Size() to call the new faiss_IndexBinary_size signature using an out-parameter. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
capemox
previously approved these changes
May 11, 2026
Co-authored-by: Copilot <copilot@github.com>
CascadingRadium
requested review from
a team,
Likith101,
Samsonnyyeet,
Thejas-bhat,
capemox,
Copilot,
maneuvertomars and
steveyen
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CascadingRadium
changed the title
Likith101
previously approved these changes
May 15, 2026
capemox
previously approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
faiss_Index_size()FAISS method in theSize()API forBinary and FP32 index classes.
Size()API for the GPU Index class.