-
Notifications
You must be signed in to change notification settings - Fork 7
[ADHOC] ci: increase build size #485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
WalkthroughA single GitHub Actions workflow was modified to set NODE_OPTIONS to increase the Node.js memory limit (--max-old-space-size=8192) for the “Build Project Artifacts” step. No steps, commands, or control flow were changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests
Comment |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/on-push-to-main.yml (1)
51-52: LGTM; also add to Release build and right-size heap.This step-level NODE_OPTIONS is fine. Two recommendations:
- Runner RAM may be <8GB; consider 4096–6144 to avoid Node refusing to start.
- Add the same env to the Release “Build” step to prevent OOM during turbo build.
Apply to Release “Build” step:
- name: Build - env: - NEXT_PUBLIC_WALLETCONNECT_PROJECT_ID: ${{ secrets.WALLETCONNECT_PROJECT_ID }} + env: + NEXT_PUBLIC_WALLETCONNECT_PROJECT_ID: ${{ secrets.WALLETCONNECT_PROJECT_ID }} + NODE_OPTIONS: --max-old-space-size=6144 run: npx turbo build --cache-dir=".cache" --filter="./packages/*"Please confirm:
- Current ubuntu-latest runner RAM (adjust heap accordingly).
- Whether prior failures occurred in Release build as well; if so, extend NODE_OPTIONS there.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
.github/workflows/on-push-to-main.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Verify / Verify
|
Description
increase build size so that we can get an sdk release out
Summary by CodeRabbit