Skip to content

Conversation

@jonathandiep
Copy link
Contributor

@jonathandiep jonathandiep commented Oct 2, 2025

Description

increase build size so that we can get an sdk release out

Summary by CodeRabbit

  • Chores
    • Improved CI build stability by increasing memory allocation during the build process, reducing intermittent out-of-memory failures on larger deployments.
    • No impact on application features or behavior; release artifacts remain unchanged.
    • Enhances reliability and consistency of deployments without requiring any action from users.

@changeset-bot
Copy link

changeset-bot bot commented Oct 2, 2025

⚠️ No Changeset found

Latest commit: 4e7c256

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "@boostxyz/test" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

@coderabbitai
Copy link

coderabbitai bot commented Oct 2, 2025

Walkthrough

A single GitHub Actions workflow was modified to set NODE_OPTIONS to increase the Node.js memory limit (--max-old-space-size=8192) for the “Build Project Artifacts” step. No steps, commands, or control flow were changed.

Changes

Cohort / File(s) Summary
CI workflow update
.github/workflows/on-push-to-main.yml
Added environment variable NODE_OPTIONS: --max-old-space-size=8192 to the Build Project Artifacts step; no other step or flow changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

I tuned the gears in the nightly run,
A bigger heap so builds don’t shun.
Eight gigs strong, the bytes take flight,
My whiskers twitch—green checks in sight.
Hop, compile, deploy—what fun! 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Title Check ⚠️ Warning The current pull request title “[ADHOC] ci: increase build size” is misleading and too vague because the change actually increases the Node.js memory limit for the CI build rather than the output size, and it includes a nonstandard “[ADHOC]” prefix. This phrasing may confuse reviewers about the scope of the change. It does not clearly summarize the main update. Please update the title to clearly and concisely describe the main change, for example “ci: increase Node.js build memory to 8 GB”, and remove unnecessary prefixes like “[ADHOC]”. A clear title helps teammates scanning the history understand the primary change at a glance.
Description Check ❓ Inconclusive The pull request includes the required “### Description” section, but the description is too brief and omits key details such as the addition of the NODE_OPTIONS variable and its purpose. It does not specify which file or step is affected in the CI workflow. This lack of detail may make it harder for reviewers to verify that the intended configuration update is correct. Please expand the description to summarize what was changed in the CI configuration, specifically the addition of the NODE_OPTIONS environment variable and why the increased memory limit is needed. Providing context about the affected workflow file and build step will improve clarity for reviewers.
✅ Passed checks (1 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch jon/increase-build-size

Comment @coderabbitai help to get the list of available commands and usage tips.

@jonathandiep
Copy link
Contributor Author

Warnings
⚠️

By using the [ADHOC] title prefix, you are bypassing best practice protections.

⚠️

Are you sure you want to be submitting a change without including a changeset? If you're just changing docs or tests, you probably don't need to. See the publishing section of the README for more info.

Generated by 🚫 dangerJS against 4e7c256

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/workflows/on-push-to-main.yml (1)

51-52: LGTM; also add to Release build and right-size heap.

This step-level NODE_OPTIONS is fine. Two recommendations:

  • Runner RAM may be <8GB; consider 4096–6144 to avoid Node refusing to start.
  • Add the same env to the Release “Build” step to prevent OOM during turbo build.

Apply to Release “Build” step:

       - name: Build
-        env:
-          NEXT_PUBLIC_WALLETCONNECT_PROJECT_ID: ${{ secrets.WALLETCONNECT_PROJECT_ID }}
+        env:
+          NEXT_PUBLIC_WALLETCONNECT_PROJECT_ID: ${{ secrets.WALLETCONNECT_PROJECT_ID }}
+          NODE_OPTIONS: --max-old-space-size=6144
         run: npx turbo build --cache-dir=".cache" --filter="./packages/*"

Please confirm:

  • Current ubuntu-latest runner RAM (adjust heap accordingly).
  • Whether prior failures occurred in Release build as well; if so, extend NODE_OPTIONS there.
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 0bf19df and 4e7c256.

📒 Files selected for processing (1)
  • .github/workflows/on-push-to-main.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Verify / Verify

@jonathandiep
Copy link
Contributor Author

Warnings
⚠️

By using the [ADHOC] title prefix, you are bypassing best practice protections.

⚠️

Are you sure you want to be submitting a change without including a changeset? If you're just changing docs or tests, you probably don't need to. See the publishing section of the README for more info.

Generated by 🚫 dangerJS against 4e7c256

@jonathandiep jonathandiep merged commit 1ccaebc into main Oct 2, 2025
7 checks passed
@jonathandiep jonathandiep deleted the jon/increase-build-size branch October 2, 2025 16:33
@coderabbitai coderabbitai bot mentioned this pull request Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants