fix: remove over-aggressive WebGL shader compilation pre-check#236
Merged
Conversation
The shader-compilation test on a detached test canvas produced false negatives on Windows (ANGLE backend) and Linux (Mesa), causing the globe to refuse initialization even when WebGL was fully functional. macOS was unaffected due to its Metal-backed WebGL implementation. Replace with a lightweight context-existence check; globe.gl's own Three.js initialization already handles deeper WebGL failures via the existing try/catch. Fixes: #234 Co-authored-by: Brian Keating <brianbruff@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shader-compilation test on a detached test canvas produced false negatives on Windows (ANGLE backend) and Linux (Mesa), causing the globe to refuse initialization even when WebGL was fully functional. macOS was unaffected due to its Metal-backed WebGL implementation.
Replace with a lightweight context-existence check; globe.gl's own Three.js initialization already handles deeper WebGL failures via the existing try/catch.
Fixes: #234