fix: handle XML namespace in test file deserialization#5
Open
smunini wants to merge 1 commit intobrianpos:masterfrom
Open
fix: handle XML namespace in test file deserialization#5smunini wants to merge 1 commit intobrianpos:masterfrom
smunini wants to merge 1 commit intobrianpos:masterfrom
Conversation
Upstream fhir-test-cases added xmlns="http://hl7.org/fhirpath/tests" to tests-fhir-r5.xml, breaking XmlSerializer deserialization. Add a DeserializeTests helper that detects the root element namespace at runtime and passes it to XmlSerializer when present. Also add a test that downloads the latest upstream XML to verify compatibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
xmlns="http://hl7.org/fhirpath/tests"totests-fhir-r5.xml(commit), breakingXmlSerializerdeserialization sinceTestFileDefinition.csdeclares[XmlRoot(ElementName = "tests")]without a namespace.DeserializeTestshelper that detects the root element's namespace at runtime and passes it toXmlSerializerwhen present, handling both old (no namespace) and new formats.TestDeserializeLatestTestsXmltest that downloads the current upstream XML and verifies namespace-aware deserialization works.