Skip to content

fix: handle XML namespace in test file deserialization #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
smunini wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: handle XML namespace in test file deserialization #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 33 additions & 3 deletions src/Test.Fhir.R5.FhirPath.Validator/Hl7UnitTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
using System.Linq;
using System.Net.Http;
using System.Text.Json;
using System.Xml;
using System.Xml.Serialization;
using Test.Fhir.R4B.FhirPath.Validator;
using Test.Fhir.R5.FhirPath.Validator;
Expand Down Expand Up @@ -83,15 +84,14 @@ public static IEnumerable<TestData> ExpressionsInTests
var result = new List<TestData>();
string testFileXml = @"c:\git\hl7\fhir-test-cases\r5\fhirpath\tests-fhir-r5.xml";
string testBasePath = @"c:\git\hl7\fhir-test-cases\r5\";
XmlSerializer serializer = new XmlSerializer(typeof(Tests));
var jsonSettings = new FhirJsonPocoDeserializerSettings() { Validator = null, AnnotateResourceParseExceptions = true, ValidateOnFailedParse = false };
var jsonDS = new FhirJsonPocoDeserializer(jsonSettings);
var xmlSettings = new FhirXmlPocoDeserializerSettings() { Validator = null, AnnotateResourceParseExceptions = true, ValidateOnFailedParse = false };
var xmlDS = new FhirXmlPocoDeserializer(xmlSettings);

using (StreamReader reader = new StreamReader(testFileXml))
using (var fs = File.OpenRead(testFileXml))
{
Tests tests = (Tests)serializer.Deserialize(reader);
Tests tests = DeserializeTests(fs);
//Console.WriteLine($"Name: {tests.Name}");
//Console.WriteLine($"{tests.Description}");
//Console.WriteLine("-----------------------------------");
Expand Down Expand Up @@ -152,6 +152,36 @@ public static IEnumerable<TestData> ExpressionsInTests
}
}

internal static Tests DeserializeTests(Stream stream)
{
using (XmlReader xmlReader = XmlReader.Create(stream))
{
xmlReader.MoveToContent();
var ns = xmlReader.NamespaceURI;
XmlSerializer serializer = string.IsNullOrEmpty(ns)
? new XmlSerializer(typeof(Tests))
: new XmlSerializer(typeof(Tests), ns);
return (Tests)serializer.Deserialize(xmlReader);
}
}

[TestMethod]
public async System.Threading.Tasks.Task TestDeserializeLatestTestsXml()
{
using var httpClient = new HttpClient();
var url = "https://raw.githubusercontent.com/FHIR/fhir-test-cases/master/r5/fhirpath/tests-fhir-r5.xml";
using var response = await httpClient.GetAsync(url);
response.EnsureSuccessStatusCode();

using var stream = await response.Content.ReadAsStreamAsync();
Tests tests = DeserializeTests(stream);

Assert.IsNotNull(tests, "Deserialized Tests object should not be null");
Assert.IsNotNull(tests.Groups, "Tests should contain groups");
Assert.IsTrue(tests.Groups.Count > 0, "Tests should contain at least one group");
Assert.IsFalse(string.IsNullOrEmpty(tests.Name), "Tests should have a name");
}

[TestMethod]
[DynamicData(nameof(TestDataKeys))]
public void CheckStaticReturnTypes(string groupName, string testName)
Expand Down