I$/D$ Cache Line Parametrization Improvements #8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
I worked recently with your fork of OpenPiton+Sargantana and I ran into some issues when trying to use 32-byte cache lines with the I$. The parametrization is I think incomplete, which led some inconsistencies (for example, for the index size) across the core_tile + sargantana + icache modules.
This PR mainly proposes to fix this. I propose to group all the icache parameters in the
sargantana_icache_pkg(some of them were removed from thedrac_pkg) and I also propose a simpler interface, similar to the one used in CVA6, where most of the parameters of the icache are computed from the icache size, its number of ways, the cache line size and the sizes of the physical/virtual addresses used. In the process, I removed some duplicated parameters and I had to replace some hardcoded values by package parameters.I'll open other PRs for the sargantana + icache submodules.
Tell me what you think :)