feat: no analyzer warning when state is generic #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the user declares a LogicBlock with a generic state (e.g., as an abstract intermediate type in an inheritance hierarchy), the analyzer no longer warns about a missing [LogicBlock] attribute, as the attribute cannot be applied to a generic type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if an intermediate type is declared in the LogicBlock inheritance hierarchy (e.g., for reusable behaviors), the analyzer will warn about a missing
[LogicBlock]attribute even when the state is still generic:However, adding the
[LogicBlock]attribute to this type is not feasible, as the state type is generic:With this change, when the user declares a LogicBlock with a generic state, the analyzer no longer warns about a missing [LogicBlock] attribute:
The analyzer does still warn if the generic type does not appear to be a state (i.e., is not a member of the type argument list to the base logic block type):