Skip to content

feat: no analyzer warning when state is generic #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: no analyzer warning when state is generic #196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions Chickensoft.LogicBlocks.Analyzers/src/LogicBlockAttributeAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,16 +32,30 @@ private void AnalyzeClassDeclaration(SyntaxNodeAnalysisContext context) {
var classDeclaration = (ClassDeclarationSyntax)context.Node;

if (
!(
classDeclaration.BaseList?.Types.FirstOrDefault()?.Type
is GenericNameSyntax genericName &&
genericName.Identifier.ValueText.EndsWith("LogicBlock")
)
classDeclaration.BaseList?.Types.FirstOrDefault()?.Type is not GenericNameSyntax baseLogicBlock ||
!baseLogicBlock.Identifier.ValueText.EndsWith("LogicBlock")
) {
// Only analyze types that appear to be logic blocks.
return;
}

// We can't apply the LogicBlock attribute to generic LogicBlock types
// if one of the generics is the state type
if (
classDeclaration.TypeParameterList is not null
&& classDeclaration.TypeParameterList.Parameters.Count > 0
&& classDeclaration.TypeParameterList.Parameters.Any(
parameter =>
baseLogicBlock.TypeArgumentList.Arguments.Any(
argument =>
argument is IdentifierNameSyntax identifierArg
&& identifierArg.Identifier.ValueText == parameter.Identifier.ValueText
)
)
) {
return;
}

var attributes = classDeclaration.AttributeLists.SelectMany(
list => list.Attributes
).Where(
Expand Down