Skip to content

build: add typecheck step - #449

Draft
AriPerkkio wants to merge 3 commits into
mainfrom
build/typescript-strict
Draft

AriPerkkio wants to merge 3 commits into
mainfrom
build/typescript-strict

Conversation

@AriPerkkio

Copy link
Copy Markdown
Member

@changeset-bot

changeset-bot Bot commented Sep 2, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 908d3ed

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Comment thread .github/workflows/test-base.yml Outdated
pnpm publint

- name: Run Typecheck
continue-on-error: true # TODO: Remove

@AriPerkkio AriPerkkio Sep 2, 2026 •

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Remove continue-on-error
  • Run pnpm typecheck and fix errors

Comment thread tsconfig.json
Comment on lines +16 to +18
// TODO: Enable "strict: true" and remove these:
"noImplicitAny": true,
"strictBindCallApply": true

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Set strict: true
  • Run pnpm typecheck and fix errors

@pkg-pr-new

pkg-pr-new Bot commented Sep 2, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

pnpm add https://pkg.pr.new/@chromatic-com/cypress@908d3ed -D
pnpm add https://pkg.pr.new/@chromatic-com/playwright@908d3ed -D
pnpm add https://pkg.pr.new/@chromatic-com/vitest@908d3ed -D

commit: 908d3ed

@AriPerkkio AriPerkkio mentioned this pull request Sep 2, 2026
12 of 18 tasks
@AriPerkkio
AriPerkkio force-pushed the chore/oxlint-oxfmt branch 3 times, most recently from 236a985 to c29269e Compare September 4, 2026 12:16
Base automatically changed from chore/oxlint-oxfmt to main September 7, 2026 13:08
@AriPerkkio
AriPerkkio force-pushed the build/typescript-strict branch 5 times, most recently from 1a96f3a to 7ab1a39 Compare September 8, 2026 09:21
@AriPerkkio
AriPerkkio force-pushed the build/typescript-strict branch from 7ab1a39 to 908d3ed Compare September 30, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant