Repository navigation
build: add typecheck step - #449
Draft
AriPerkkio wants to merge 3 commits into
Draft
AriPerkkio wants to merge 3 commits into
AriPerkkio wants to merge 3 commits into
Conversation
|
AriPerkkio
commented
Sep 2, 2026
| pnpm publint | ||
|
|
||
| - name: Run Typecheck | ||
| continue-on-error: true # TODO: Remove |
Member
Author
There was a problem hiding this comment.
- Remove
continue-on-error - Run
pnpm typecheckand fix errors
AriPerkkio
commented
Sep 2, 2026
Comment on lines
+16
to
+18
| // TODO: Enable "strict: true" and remove these: | ||
| "noImplicitAny": true, | ||
| "strictBindCallApply": true |
Member
Author
There was a problem hiding this comment.
- Set
strict: true - Run
pnpm typecheckand fix errors
commit: |
12 of 18 tasks
AriPerkkio
force-pushed
the
chore/oxlint-oxfmt
branch
3 times, most recently
from
September 4, 2026 12:16
236a985 to
c29269e
Compare
AriPerkkio
force-pushed
the
build/typescript-strict
branch
5 times, most recently
from
September 8, 2026 09:21
1a96f3a to
7ab1a39
Compare
AriPerkkio
force-pushed
the
build/typescript-strict
branch
from
September 30, 2026 11:56
7ab1a39 to
908d3ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
eslint+prettierwithoxlint+oxfmt#448What Changed
How to test