update TransferIntent id type to bytes32 #18
Conversation
🟡 Heimdall Review Status
|
|
Review Error for TELLYWHALE @ 2024-08-11 00:05:58 UTC |
|
Review Error for TELLYWHALE @ 2024-08-11 00:30:59 UTC |
|
Review Error for Nichebiche @ 2024-08-27 21:09:33 UTC |
|
Review Error for MTerrases22 @ 2024-09-21 22:09:21 UTC |
|
Review Error for Nichebiche @ 2024-09-21 22:14:21 UTC |
|
Review Error for Irasone @ 2024-09-21 22:43:13 UTC |
|
Review Error for Irasone @ 2024-09-21 22:44:29 UTC |
|
Why haven't I received payment? I've been mistreated here. This is my account and no one should be preventing me from it. I'm so not letting this one go . I can't retrieve my funds. Someone took my identity and keeps locking me out of my account. I want my account left alone. It's my money not anyone else's. |
|
What am I supposed to do with this
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Sturgeontara06 ***@***.***>
Sent: Thursday, October 10, 2024 5:17:24 PM
To: coinbase/commerce-onchain-payment-protocol ***@***.***>
Cc: Marlyn Elizabeth Terrases ***@***.***>; Comment ***@***.***>
Subject: Re: [coinbase/commerce-onchain-payment-protocol] update TransferIntent id type to bytes32 (PR #18)
@Sturgeontara06 commented on this pull request.
Sure
—
Reply to this email directly, view it on GitHub<#18 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BKBCEVRTDEKIT4I26JEKKLTZ24KJJAVCNFSM6AAAAABMBGYTBKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNRRGY2TMNJVGU>.
You are receiving this because you commented.Message ID: ***@***.***>
|
|
Review Error for Irasone @ 2024-10-11 01:46:04 UTC |
|
Please check now.
Was this taken care of?
…On Thu, Oct 10, 2024 at 6:46 PM Heimdall ***@***.***> wrote:
Review Error for Irasone @ 2024-10-11 01:46:04 UTC
User must have write permissions to review
—
Reply to this email directly, view it on GitHub
<#18 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BKBCEVV2W734MHHH7XEHXZDZ24UXFAVCNFSM6AAAAABMBGYTBKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBWGM3TGMJWGI>
.
You are receiving this because you commented.Message ID:
***@***.***
com>
--
*Marlyn E.Terrases*
|
|
Awesome, thank you so much!
…On Thu, Oct 10, 2024 at 6:46 PM Irasone ***@***.***> wrote:
***@***.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
<#18 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BKBCEVU2SJTN3OIAJ43B5MLZ24UW5AVCNFSM6AAAAABMBGYTBKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNRRG42TSMRSGQ>
.
You are receiving this because you commented.Message ID:
<coinbase/commerce-onchain-payment-protocol/pull/18/review/2361759224@
github.com>
--
*Marlyn E.Terrases*
|
|
How can I access that check. With authorization of course. Been locked out and unable to claim my assets.someone please help me. |
|
Hello,
I haven't been getting my emails.
…On Sat, Sep 21, 2024 at 3:44 PM Heimdall ***@***.***> wrote:
Review Error for Irasone @ 2024-09-21 22:44:29 UTC
User must have write permissions to review
—
Reply to this email directly, view it on GitHub
<#18 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BKBCEVT74XR3KDXOWRJQ76DZXXZGHAVCNFSM6AAAAABMBGYTBKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRVGM2DKMBZGE>
.
You are receiving this because you commented.Message ID:
***@***.***
com>
--
*Marlyn E.Terrases*
|
|
Review Error for Tinaochoa8462 @ 2024-10-24 07:38:24 UTC |
|
Review Error for joeltato @ 2024-11-07 11:33:52 UTC |
|
how get my funds
…On Thu, Nov 7, 2024 at 5:34 AM Heimdall ***@***.***> wrote:
Review Error for joeltato @ 2024-11-07 11:33:52 UTC
User must have write permissions to review
—
Reply to this email directly, view it on GitHub
<#18 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BMUM4PVE4A55VG7KR4S35DTZ7NF3NAVCNFSM6AAAAABMBGYTBKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRSGAYDKNJZGQ>
.
You are receiving this because you commented.Message ID:
***@***.***
com>
|
|
Review Error for zwiux42 @ 2024-12-06 22:54:23 UTC |
|
Review Error for zwiux42 @ 2024-12-07 01:08:15 UTC |
|
Review Error for Irasone @ 2024-12-08 10:51:13 UTC |
|
Review Error for Irasone @ 2024-12-08 10:52:46 UTC |
| uint256 deadline; | ||
| address payable recipient; | ||
| address recipientCurrency; | ||
| address refundDestination; |
There was a problem hiding this comment.
ETH: 0x0bf26aa3363696ec93fc88476e131e889310389c
| uint256 recipientAmount; | ||
| uint256 deadline; | ||
| address payable recipient; | ||
| address recipientCurrency; |
There was a problem hiding this comment.
7add5225-44df-4e1b-86f7-326b3cc7b89b
|
Review Error for justpayme3 @ 2025-01-23 21:37:29 UTC |
|
Review Error for Irasone @ 2025-01-23 21:42:42 UTC |
|
Review Error for Irasone @ 2025-01-23 21:48:23 UTC |
|
Review Error for Nichebiche @ 2025-01-23 22:00:14 UTC |
|
Review Error for Nichebiche @ 2025-01-23 22:03:31 UTC |
10 participants
Hi,
I was wondering if the
idfield of theTransferIntentcould be updated to abytes32instead ofbytes16.This would make it so the Keccak256 hash function could be used to generate predictable ids and be more compatible with other protocols generating ids with Keccak256.
For my use case, I'm using EAS (Ethereum Attestation Service) as a backend to create an on-chain eCommerce solution, and it would be nice if I could use an attestation UID (a Keccak256 hash of the attestation) as the
idfor theTransferIntent. This would make the relationship between an attestation and aTransferIntentsimpler and more efficient.Thanks for your consideration and for this awesome protocol.