Skip to content

update TransferIntent id type to bytes32 #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Open

update TransferIntent id type to bytes32 #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions contracts/interfaces/ITransfers.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ struct TransferIntent {
address recipientCurrency;
Copy link

@justpayme3 justpayme3 Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7add5225-44df-4e1b-86f7-326b3cc7b89b

address refundDestination;
Copy link

@justpayme3 justpayme3 Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ETH: 0x0bf26aa3363696ec93fc88476e131e889310389c

uint256 feeAmount;
bytes16 id;
bytes32 id;
address operator;
bytes signature;
bytes prefix;
Expand Down Expand Up @@ -52,7 +52,7 @@ interface ITransfers {
// @param spentCurrency What currency the payer sent
event Transferred(
address indexed operator,
bytes16 id,
bytes32 id,
address recipient,
address sender,
uint256 spentAmount,
Expand Down
2 changes: 1 addition & 1 deletion contracts/transfers/Transfers.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ contract Transfers is Context, Ownable, Pausable, ReentrancyGuard, Sweepable, IT
mapping(address => address) private feeDestinations;

// @dev Map of operator addresses to a map of transfer intent ids that have been processed
mapping(address => mapping(bytes16 => bool)) private processedTransferIntents;
mapping(address => mapping(bytes32 => bool)) private processedTransferIntents;

// @dev Represents native token of a chain (e.g. ETH or MATIC)
address private immutable NATIVE_CURRENCY = address(0);
Expand Down