-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Honda DBC updates #2794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vanillagorillaa
wants to merge
12
commits into
commaai:master
Choose a base branch
from
vanillagorillaa:honda_updates
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Honda DBC updates #2794
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
52daa20
Honda DBC updates
vanillagorillaa 7e46aa9
fix min max
vanillagorillaa 6501ec1
update name
vanillagorillaa 66f3c5a
wrong offset
vanillagorillaa db0012d
remove
vanillagorillaa 801e033
update name
vanillagorillaa 1ebe8fe
add
vanillagorillaa 89b428e
Merge branch 'master' into honda_updates
vanillagorillaa 92db3eb
kinematics rebase
vanillagorillaa 76b12bc
more signals
vanillagorillaa 6f8d9f3
put back, fix in seperate PR
vanillagorillaa 00cef5c
remove this too
vanillagorillaa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,6 +5,8 @@ BO_ 662 SCM_BUTTONS: 4 SCM | |
SG_ COUNTER : 29|2@0+ (1,0) [0|3] "" EON | ||
|
||
BO_ 806 SCM_FEEDBACK: 8 SCM | ||
SG_ BOH_DIF_1 : 5|6@0+ (1,0) [0|63] "" XXX | ||
SG_ BOH_DIF_2 : 14|7@0+ (1,0) [0|127] "" XXX | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. These seem to be a differential pair to each other There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I can just remove this. I don't have any idea what it may be. Can add back in after further clean up |
||
SG_ DRIVERS_DOOR_OPEN : 17|1@0+ (1,0) [0|1] "" XXX | ||
SG_ REVERSE_LIGHT : 18|1@0+ (1,0) [0|1] "" EON | ||
SG_ CMBS_BUTTON : 22|2@0+ (1,0) [0|3] "" EON | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is another one we should consolidate, _nidec_scm_group_b is the same thing as Bosch, needs a round of generator cleanup. Same as KINEMATICS, just got done doing a bunch of generator cleanup and want to avoid adding new drift/rot where every car's version of that message ends up being slightly different. I'll do the cleanup myself at some point if you don't have time.