Honda DBC updates #2794
Honda DBC updates #2794
Conversation
|
|
||
| BO_ 806 SCM_FEEDBACK: 8 SCM | ||
| SG_ BOH_DIF_1 : 5|6@0+ (1,0) [0|63] "" XXX | ||
| SG_ BOH_DIF_2 : 14|7@0+ (1,0) [0|127] "" XXX |
There was a problem hiding this comment.
These seem to be a differential pair to each other
There was a problem hiding this comment.
I can just remove this. I don't have any idea what it may be. Can add back in after further clean up
|
Setting to draft while you're still tinkering, just remove from draft when you're ready. |
Probably never truly done tinkering, will probably just keep adding as I hunt and find stuff. Would you prefer smaller PR's with a few new signals, or one larger one? |
Somewhat bigger (but not crazy) PRs are mostly fine for signals that openpilot doesn't actively use. For anything that alters a signal actively used by openpilot, try to keep PRs down to a single message or other minimal grouping for ease of validation. I don't think you have anything like that here. |
| SG_ CHECKSUM : 27|4@0+ (1,0) [0|3] "" EON | ||
| SG_ COUNTER : 29|2@0+ (1,0) [0|3] "" EON | ||
|
|
||
| BO_ 806 SCM_FEEDBACK: 8 SCM |
There was a problem hiding this comment.
This is another one we should consolidate, _nidec_scm_group_b is the same thing as Bosch, needs a round of generator cleanup. Same as KINEMATICS, just got done doing a bunch of generator cleanup and want to avoid adding new drift/rot where every car's version of that message ends up being slightly different. I'll do the cleanup myself at some point if you don't have time.
2 participants
Nerd sniped myself looking for a different signal.
39563a18fe07169f/00000028--d3800a1d4b