Clean up bmi_waves.c

[mcflugen]

I've cleaned up the bmi_waves.c. It now uses a table of variables that lists variable names and metadata.

[Copilot]

Pull Request Overview

The PR refactors bmi_waves.c to replace repetitive per-variable logic with a centralized VarInfo table and lookup function.

• Introduces VarInfo struct and a static variables[] table to centralize metadata.
• Adds find_variable() for DRY lookups in get_var_type, get_var_units, get_var_itemsize, and get_var_location.
• Cleans up function brace styles and removes long chains of if/else.

Comments suppressed due to low confidence (4)

bmi_waves.c:15

• [nitpick] The field name type is generic; consider renaming it to data_type to clarify its purpose and avoid confusion with C/C++ keywords.

const char *type;

bmi_waves.c:312

• Consider adding unit tests for the variable getters (type, units, itemsize, location) to cover both valid and invalid names, ensuring error paths are handled correctly.

const VarInfo *var = find_variable(name);

bmi_waves.c:59

• [nitpick] Indentation here mixes tabs and spaces; align with the project style (e.g., spaces only) to improve consistency.

size_t i;

bmi_waves.c:60

• This linear search may become a bottleneck if variables grows large; consider using a lookup table or hash map for O(1) lookup.

for (i = 0; i < VAR_COUNT; i++) {

[Copilot]

Add a brief comment explaining the VarInfo struct and its purpose for improved code readability.

Suggested change

	/*
	* VarInfo is a structure used to store metadata about a variable.
	* - name: The name of the variable.
	* - units: The units in which the variable is measured.
	* - type: The data type of the variable (e.g., "double").
	* - itemsize: The size of one item of the variable's type, in bytes.
	*/