Skip to content

Conversation

KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Sep 4, 2025

This is the fourth PR in the series to reach the YAML compilation speed-up.
It is based on and incorporates #9926, #9929 and #9948. For ease of review, it's targeted parent branch instead of master.

This updates the Jinja transpilation flow to reuse the existing YAML transpilation flow and respect different options (js, threads, native) instead of doing in-place transpilation only. Also cache for rendered jinja files is introduced.

Check List

  • Tests have been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet

Copy link

codecov bot commented Sep 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.62%. Comparing base (61f15ab) to head (7281399).
⚠️ Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9950      +/-   ##
==========================================
+ Coverage   84.60%   84.62%   +0.02%     
==========================================
  Files         253      253              
  Lines       89874    89982     +108     
==========================================
+ Hits        76038    76148     +110     
+ Misses      13836    13834       -2     
Flag Coverage Δ
cubesql 84.62% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KSDaemon KSDaemon force-pushed the perf/jinja-compile-streamline branch 2 times, most recently from 6c8dc9d to 7281399 Compare September 4, 2025 20:09
@KSDaemon KSDaemon changed the base branch from master to perf/yaml-transpile-native September 5, 2025 09:09
@KSDaemon KSDaemon force-pushed the perf/jinja-compile-streamline branch 2 times, most recently from bebb247 to 01531cd Compare September 5, 2025 11:22
@KSDaemon KSDaemon force-pushed the perf/yaml-transpile-native branch from 72c595e to a15bbac Compare September 5, 2025 13:00
@KSDaemon KSDaemon force-pushed the perf/jinja-compile-streamline branch from 01531cd to f3bd485 Compare September 5, 2025 13:01
@KSDaemon KSDaemon marked this pull request as ready for review September 5, 2025 14:52
@KSDaemon KSDaemon requested a review from a team as a code owner September 5, 2025 14:52
@KSDaemon KSDaemon force-pushed the perf/yaml-transpile-native branch from a15bbac to 5df8c61 Compare September 8, 2025 11:34
@KSDaemon KSDaemon requested a review from a team as a code owner September 8, 2025 11:34
@KSDaemon KSDaemon force-pushed the perf/jinja-compile-streamline branch from d821379 to e425c3b Compare September 8, 2025 11:35
@KSDaemon KSDaemon force-pushed the perf/yaml-transpile-native branch from 5df8c61 to b518579 Compare September 9, 2025 09:17
@KSDaemon KSDaemon force-pushed the perf/jinja-compile-streamline branch from 98b313b to fc860fe Compare September 9, 2025 09:25
@KSDaemon KSDaemon force-pushed the perf/yaml-transpile-native branch from b518579 to 3a76955 Compare September 9, 2025 13:54
@KSDaemon KSDaemon force-pushed the perf/jinja-compile-streamline branch from fc860fe to e47169e Compare September 9, 2025 13:55
@KSDaemon KSDaemon force-pushed the perf/yaml-transpile-native branch from 3a76955 to 27e49fa Compare September 10, 2025 06:48
@KSDaemon KSDaemon force-pushed the perf/jinja-compile-streamline branch from e47169e to 2dd8187 Compare September 10, 2025 06:49
@KSDaemon KSDaemon force-pushed the perf/yaml-transpile-native branch from 27e49fa to 03a1603 Compare September 11, 2025 09:44
@KSDaemon KSDaemon force-pushed the perf/jinja-compile-streamline branch 2 times, most recently from c8b93ae to 67a1361 Compare September 11, 2025 10:26
@KSDaemon KSDaemon changed the title perf(schema-compiler): Improve jinja compilation speed perf(schema-compiler): Introduce compiledJinjaCache Sep 11, 2025
@KSDaemon KSDaemon force-pushed the perf/yaml-transpile-native branch from a01b6ca to 86460e0 Compare September 11, 2025 10:43
@KSDaemon KSDaemon force-pushed the perf/jinja-compile-streamline branch from 244dabb to 5d0d95a Compare September 11, 2025 10:51
@KSDaemon KSDaemon force-pushed the perf/yaml-transpile-native branch from 86460e0 to 13f228c Compare September 11, 2025 11:07
@KSDaemon KSDaemon force-pushed the perf/jinja-compile-streamline branch from 5d0d95a to c818128 Compare September 11, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant