-
Notifications
You must be signed in to change notification settings - Fork 1.9k
perf(schema-compiler): Introduce compiledJinjaCache #9950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KSDaemon
wants to merge
4
commits into
perf/yaml-transpile-native
Choose a base branch
from
perf/jinja-compile-streamline
base: perf/yaml-transpile-native
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
perf(schema-compiler): Introduce compiledJinjaCache #9950
KSDaemon
wants to merge
4
commits into
perf/yaml-transpile-native
from
perf/jinja-compile-streamline
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9950 +/- ##
==========================================
+ Coverage 84.60% 84.62% +0.02%
==========================================
Files 253 253
Lines 89874 89982 +108
==========================================
+ Hits 76038 76148 +110
+ Misses 13836 13834 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
6c8dc9d
to
7281399
Compare
bebb247
to
01531cd
Compare
72c595e
to
a15bbac
Compare
01531cd
to
f3bd485
Compare
a15bbac
to
5df8c61
Compare
d821379
to
e425c3b
Compare
5df8c61
to
b518579
Compare
98b313b
to
fc860fe
Compare
b518579
to
3a76955
Compare
fc860fe
to
e47169e
Compare
3 tasks
3a76955
to
27e49fa
Compare
e47169e
to
2dd8187
Compare
27e49fa
to
03a1603
Compare
c8b93ae
to
67a1361
Compare
a01b6ca
to
86460e0
Compare
244dabb
to
5d0d95a
Compare
86460e0
to
13f228c
Compare
5d0d95a
to
c818128
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fourth PR in the series to reach the YAML compilation speed-up.
It is based on and incorporates #9926, #9929 and #9948. For ease of review, it's targeted parent branch instead of master.
This updates the Jinja transpilation flow to reuse the existing YAML transpilation flow and respect different options (js, threads, native) instead of doing in-place transpilation only. Also cache for rendered jinja files is introduced.
Check List