-
Notifications
You must be signed in to change notification settings - Fork 8
Update library build #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
There were some major overhauls to Cycamore's CMake infrastructure in the 2nd half of last year that should simplify things if they were to be transferred to here |
|
My first thought for this update was to copy over what is in Cycamore and then just update the library name. That ended up causing some issues because the |
Hmmm.... this is definitely not a conventional design.... some thought will be required. |
|
Besides some things in the repo structure being unconventional and worth re-visiting, is there anything that should be updated with this PR? |
|
Does it work? I know that there was substantial restructuring of CMake and its macros, so I'm not sure if that kind of restructuring makes sense here, just on the CMake side, never mind the code side. |
|
We might be better off, after all, starting in a clean repo for advanced archetypes, and then moving Pyre into that repo...??? |
|
It builds on my machine (rocky 8.9). When I get around to updating the CI I can run on other machine types. I'm not against moving this to a new repo, but the benefit of that is not clear to me. |
Let's leave things here. It is probably worth taking a look at the current version of Cycamore's Alternatively, we could make that a separate issue and just go forward with this now that it builds. |
I made issue #26 to capture this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we need to update CI first so we have tests that show this building. Or maybe they need to be part of the same PR?
This PR updates the
CMakeLists.txtfile to require at least C++ 14so that the project can be built. The project builds and the unit tests inrecycle_unit_testsexecutable all pass locally.